From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep Date: Mon, 1 Jun 2015 10:12:09 -0700 Message-ID: <20150601171209.GW30984@atomide.com> References: <1432136322-7609-1-git-send-email-robertcnelson@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:55089 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbbFARMM (ORCPT ); Mon, 1 Jun 2015 13:12:12 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Robert Nelson Cc: Matthijs van Duin , devicetree , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Felipe Balbi , Johan Hovold * Robert Nelson [150531 19:20]: > On Sun, May 31, 2015 at 7:20 PM, Matthijs van Duin > wrote: > > Sorry for the late response, I only just noticed this since I wasn't CC'd. > > > > This "fix" was not ever Reported-By or Tested-By me as it claims. It > > is in fact wrong: &rtc { system-power-controller; } needs to be > > present for every variety of beaglebone (more generally every design > > with a TPS65217 whose PWR_EN is connected to the PMIC_POWER_EN pin of > > an AM335x). > > > > Without a system-power-controller, the kernel has no way of turning > > off the system and shutdown will leave the system halted instead. > > > > The previously posted fix, which added &tps { > > ti,pmic-shutdown-controller; } was correct, and ensures that a > > poweroff makes the pmic enter "OFF-state" rather than "SLEEP-state" > > (aka RTC-only sleep). > > Sorry Matthijs, (and everyone else) > > That's my fault for completely screwing up this patch.. Hmm OK. So do we now have a situation in the mainline that can potentially cause hardware damage? It seems we don't need to revert anything, just apply Matthijs' new patch? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Mon, 1 Jun 2015 10:12:09 -0700 Subject: [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep In-Reply-To: References: <1432136322-7609-1-git-send-email-robertcnelson@gmail.com> Message-ID: <20150601171209.GW30984@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Robert Nelson [150531 19:20]: > On Sun, May 31, 2015 at 7:20 PM, Matthijs van Duin > wrote: > > Sorry for the late response, I only just noticed this since I wasn't CC'd. > > > > This "fix" was not ever Reported-By or Tested-By me as it claims. It > > is in fact wrong: &rtc { system-power-controller; } needs to be > > present for every variety of beaglebone (more generally every design > > with a TPS65217 whose PWR_EN is connected to the PMIC_POWER_EN pin of > > an AM335x). > > > > Without a system-power-controller, the kernel has no way of turning > > off the system and shutdown will leave the system halted instead. > > > > The previously posted fix, which added &tps { > > ti,pmic-shutdown-controller; } was correct, and ensures that a > > poweroff makes the pmic enter "OFF-state" rather than "SLEEP-state" > > (aka RTC-only sleep). > > Sorry Matthijs, (and everyone else) > > That's my fault for completely screwing up this patch.. Hmm OK. So do we now have a situation in the mainline that can potentially cause hardware damage? It seems we don't need to revert anything, just apply Matthijs' new patch? Regards, Tony