diff for duplicates of <20150602093323.GI3329@x1> diff --git a/a/1.txt b/N1/1.txt index 3decd27..2d7022d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,16 +5,12 @@ On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: > >>>On Sat, 30 May 2015, Vaibhav Hiremath wrote: > >>> > >>>>RTC in pmic 88PM800 can run even the core is powered off, and user -> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will powe= -r up -> >>>>the core, and the whole system will boot up. And during PMIC driver p= -robe, -> >>>>it will read some register to find out whether this boot is caused by= - RTC +> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will power up +> >>>>the core, and the whole system will boot up. And during PMIC driver probe, +> >>>>it will read some register to find out whether this boot is caused by RTC > >>>>timeout or not, and pass on this information to the RTC driver. > >>>> -> >>>>So we need rtc platform data to be existed in PMIC driver to pass thi= -s +> >>>>So we need rtc platform data to be existed in PMIC driver to pass this > >>>>information. > >>>> > >>>>Signed-off-by: Chao Xie <chao.xie@marvell.com> @@ -27,24 +23,21 @@ s > >>>>index 8ea4467..34546a1 100644 > >>>>--- a/drivers/mfd/88pm800.c > >>>>+++ b/drivers/mfd/88pm800.c -> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client= -, +> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client, > >>>> return ret; > >>>> } > >>>> > >>>>+ /* -> >>>>+ * RTC in pmic can run even the core is powered off, and user can s= -et +> >>>>+ * RTC in pmic can run even the core is powered off, and user can set > >>>>+ * alarm in RTC. When the alarm is time out, the PMIC will power up > >>>>+ * the core, and the whole system will boot up. When PMIC driver is > >>>>+ * probed, it will read out some register to find out whether this > >>>>+ * boot is caused by RTC timeout or not, and it need pass this > >>>>+ * information to RTC driver. -> >>>>+ * So we need rtc platform data to be existed to pass this informat= -ion. +> >>>>+ * So we need rtc platform data to be existed to pass this information. > >>>>+ */ > >>>>+ if (!pdata->rtc) { -> >>>>+ pdata->rtc =3D devm_kzalloc(&client->dev, +> >>>>+ pdata->rtc = devm_kzalloc(&client->dev, > >>>>+ sizeof(*(pdata->rtc)), GFP_KERNEL); > >>>>+ if (!pdata->rtc) { > >>>>+ dev_err(&client->dev, @@ -68,7 +61,7 @@ ion. > >>drivers/rtc/rtc-88pm800.c [sets the "platform_data" field] > > > >Then were is the platform_data field subsequently used? ->=20 +> > Currently not used, but it is for future use, where we would be > interested to know that the wakeup is really from reset or RTC wakeup. @@ -85,28 +78,15 @@ patch to that set and I can re-review it then. > >}; > > > >Is 'vrtc' even used? If so, where? ->=20 +> > No, it is not. So either submit a patch-set that makes use of them, or let me know that you're not going to do that and I'll remove it altogether. Likewise for rtc_wakeup. ---=20 +-- Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org =E2=94=82 Open source software for ARM SoCs +Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog - ---=20 ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index de00228..241b39f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,19 +4,10 @@ "ref\0556D3A14.6050505@linaro.org\0" "ref\020150602074004.GH3329@x1\0" "ref\0556D71F6.4030608@linaro.org\0" - "From\0Lee Jones <lee.jones@linaro.org>\0" - "Subject\0[rtc-linux] Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier\0" + "From\0lee.jones@linaro.org (Lee Jones)\0" + "Subject\0[PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier\0" "Date\0Tue, 2 Jun 2015 10:33:23 +0100\0" - "To\0Vaibhav Hiremath <vaibhav.hiremath@linaro.org>\0" - "Cc\0linux-arm-kernel@lists.infradead.org" - robh+dt@kernel.org - devicetree@vger.kernel.org - linux-kernel@vger.kernel.org - rtc-linux@googlegroups.com - sameo@linux.intel.com - a.zummo@towertech.it - alexandre.belloni@free-electrons.com - " Chao Xie <chao.xie@marvell.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Tue, 02 Jun 2015, Vaibhav Hiremath wrote:\n" @@ -26,16 +17,12 @@ "> >>>On Sat, 30 May 2015, Vaibhav Hiremath wrote:\n" "> >>>\n" "> >>>>RTC in pmic 88PM800 can run even the core is powered off, and user\n" - "> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will powe=\n" - "r up\n" - "> >>>>the core, and the whole system will boot up. And during PMIC driver p=\n" - "robe,\n" - "> >>>>it will read some register to find out whether this boot is caused by=\n" - " RTC\n" + "> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will power up\n" + "> >>>>the core, and the whole system will boot up. And during PMIC driver probe,\n" + "> >>>>it will read some register to find out whether this boot is caused by RTC\n" "> >>>>timeout or not, and pass on this information to the RTC driver.\n" "> >>>>\n" - "> >>>>So we need rtc platform data to be existed in PMIC driver to pass thi=\n" - "s\n" + "> >>>>So we need rtc platform data to be existed in PMIC driver to pass this\n" "> >>>>information.\n" "> >>>>\n" "> >>>>Signed-off-by: Chao Xie <chao.xie@marvell.com>\n" @@ -48,24 +35,21 @@ "> >>>>index 8ea4467..34546a1 100644\n" "> >>>>--- a/drivers/mfd/88pm800.c\n" "> >>>>+++ b/drivers/mfd/88pm800.c\n" - "> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client=\n" - ",\n" + "> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client,\n" "> >>>> \t\t\treturn ret;\n" "> >>>> \t}\n" "> >>>>\n" "> >>>>+\t/*\n" - "> >>>>+\t * RTC in pmic can run even the core is powered off, and user can s=\n" - "et\n" + "> >>>>+\t * RTC in pmic can run even the core is powered off, and user can set\n" "> >>>>+\t * alarm in RTC. When the alarm is time out, the PMIC will power up\n" "> >>>>+\t * the core, and the whole system will boot up. When PMIC driver is\n" "> >>>>+\t * probed, it will read out some register to find out whether this\n" "> >>>>+\t * boot is caused by RTC timeout or not, and it need pass this\n" "> >>>>+\t * information to RTC driver.\n" - "> >>>>+\t * So we need rtc platform data to be existed to pass this informat=\n" - "ion.\n" + "> >>>>+\t * So we need rtc platform data to be existed to pass this information.\n" "> >>>>+\t */\n" "> >>>>+\tif (!pdata->rtc) {\n" - "> >>>>+\t\tpdata->rtc =3D devm_kzalloc(&client->dev,\n" + "> >>>>+\t\tpdata->rtc = devm_kzalloc(&client->dev,\n" "> >>>>+\t\t\t\t\t sizeof(*(pdata->rtc)), GFP_KERNEL);\n" "> >>>>+\t\tif (!pdata->rtc) {\n" "> >>>>+\t\t\tdev_err(&client->dev,\n" @@ -89,7 +73,7 @@ "> >>drivers/rtc/rtc-88pm800.c\t[sets the \"platform_data\" field]\n" "> >\n" "> >Then were is the platform_data field subsequently used?\n" - ">=20\n" + "> \n" "> Currently not used, but it is for future use, where we would be\n" "> interested to know that the wakeup is really from reset or RTC wakeup.\n" "\n" @@ -106,30 +90,17 @@ "> >};\n" "> >\n" "> >Is 'vrtc' even used? If so, where?\n" - ">=20\n" + "> \n" "> No, it is not.\n" "\n" "So either submit a patch-set that makes use of them, or let me know\n" "that you're not going to do that and I'll remove it altogether.\n" "Likewise for rtc_wakeup.\n" "\n" - "--=20\n" + "-- \n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org =E2=94=82 Open source software for ARM SoCs\n" - "Follow Linaro: Facebook | Twitter | Blog\n" - "\n" - "--=20\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + "Linaro.org ? Open source software for ARM SoCs\n" + Follow Linaro: Facebook | Twitter | Blog -603ed66d92fc38e06585169782b06f027969beb7c4ba2ebc3aeb896c4201297c +e79357cf4405e9c2498fe2ed2a8b71024e89a48f3408000e4abe10f3e143778d
diff --git a/a/1.txt b/N2/1.txt index 3decd27..ade561b 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -5,20 +5,16 @@ On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: > >>>On Sat, 30 May 2015, Vaibhav Hiremath wrote: > >>> > >>>>RTC in pmic 88PM800 can run even the core is powered off, and user -> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will powe= -r up -> >>>>the core, and the whole system will boot up. And during PMIC driver p= -robe, -> >>>>it will read some register to find out whether this boot is caused by= - RTC +> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will power up +> >>>>the core, and the whole system will boot up. And during PMIC driver probe, +> >>>>it will read some register to find out whether this boot is caused by RTC > >>>>timeout or not, and pass on this information to the RTC driver. > >>>> -> >>>>So we need rtc platform data to be existed in PMIC driver to pass thi= -s +> >>>>So we need rtc platform data to be existed in PMIC driver to pass this > >>>>information. > >>>> -> >>>>Signed-off-by: Chao Xie <chao.xie@marvell.com> -> >>>>Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> +> >>>>Signed-off-by: Chao Xie <chao.xie-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org> +> >>>>Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > >>>>--- > >>>> drivers/mfd/88pm800.c | 19 +++++++++++++++++++ > >>>> 1 file changed, 19 insertions(+) @@ -27,24 +23,21 @@ s > >>>>index 8ea4467..34546a1 100644 > >>>>--- a/drivers/mfd/88pm800.c > >>>>+++ b/drivers/mfd/88pm800.c -> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client= -, +> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client, > >>>> return ret; > >>>> } > >>>> > >>>>+ /* -> >>>>+ * RTC in pmic can run even the core is powered off, and user can s= -et +> >>>>+ * RTC in pmic can run even the core is powered off, and user can set > >>>>+ * alarm in RTC. When the alarm is time out, the PMIC will power up > >>>>+ * the core, and the whole system will boot up. When PMIC driver is > >>>>+ * probed, it will read out some register to find out whether this > >>>>+ * boot is caused by RTC timeout or not, and it need pass this > >>>>+ * information to RTC driver. -> >>>>+ * So we need rtc platform data to be existed to pass this informat= -ion. +> >>>>+ * So we need rtc platform data to be existed to pass this information. > >>>>+ */ > >>>>+ if (!pdata->rtc) { -> >>>>+ pdata->rtc =3D devm_kzalloc(&client->dev, +> >>>>+ pdata->rtc = devm_kzalloc(&client->dev, > >>>>+ sizeof(*(pdata->rtc)), GFP_KERNEL); > >>>>+ if (!pdata->rtc) { > >>>>+ dev_err(&client->dev, @@ -68,7 +61,7 @@ ion. > >>drivers/rtc/rtc-88pm800.c [sets the "platform_data" field] > > > >Then were is the platform_data field subsequently used? ->=20 +> > Currently not used, but it is for future use, where we would be > interested to know that the wakeup is really from reset or RTC wakeup. @@ -85,28 +78,19 @@ patch to that set and I can re-review it then. > >}; > > > >Is 'vrtc' even used? If so, where? ->=20 +> > No, it is not. So either submit a patch-set that makes use of them, or let me know that you're not going to do that and I'll remove it altogether. Likewise for rtc_wakeup. ---=20 +-- Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org =E2=94=82 Open source software for ARM SoCs +Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog - ---=20 ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index de00228..4618a73 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,19 +4,20 @@ "ref\0556D3A14.6050505@linaro.org\0" "ref\020150602074004.GH3329@x1\0" "ref\0556D71F6.4030608@linaro.org\0" - "From\0Lee Jones <lee.jones@linaro.org>\0" - "Subject\0[rtc-linux] Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier\0" + "ref\0556D71F6.4030608-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org\0" + "From\0Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>\0" + "Subject\0Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier\0" "Date\0Tue, 2 Jun 2015 10:33:23 +0100\0" - "To\0Vaibhav Hiremath <vaibhav.hiremath@linaro.org>\0" - "Cc\0linux-arm-kernel@lists.infradead.org" - robh+dt@kernel.org - devicetree@vger.kernel.org - linux-kernel@vger.kernel.org - rtc-linux@googlegroups.com - sameo@linux.intel.com - a.zummo@towertech.it - alexandre.belloni@free-electrons.com - " Chao Xie <chao.xie@marvell.com>\0" + "To\0Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>\0" + "Cc\0linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" + robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org + sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org + a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org + alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org + " Chao Xie <chao.xie-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>\0" "\00:1\0" "b\0" "On Tue, 02 Jun 2015, Vaibhav Hiremath wrote:\n" @@ -26,20 +27,16 @@ "> >>>On Sat, 30 May 2015, Vaibhav Hiremath wrote:\n" "> >>>\n" "> >>>>RTC in pmic 88PM800 can run even the core is powered off, and user\n" - "> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will powe=\n" - "r up\n" - "> >>>>the core, and the whole system will boot up. And during PMIC driver p=\n" - "robe,\n" - "> >>>>it will read some register to find out whether this boot is caused by=\n" - " RTC\n" + "> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will power up\n" + "> >>>>the core, and the whole system will boot up. And during PMIC driver probe,\n" + "> >>>>it will read some register to find out whether this boot is caused by RTC\n" "> >>>>timeout or not, and pass on this information to the RTC driver.\n" "> >>>>\n" - "> >>>>So we need rtc platform data to be existed in PMIC driver to pass thi=\n" - "s\n" + "> >>>>So we need rtc platform data to be existed in PMIC driver to pass this\n" "> >>>>information.\n" "> >>>>\n" - "> >>>>Signed-off-by: Chao Xie <chao.xie@marvell.com>\n" - "> >>>>Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>\n" + "> >>>>Signed-off-by: Chao Xie <chao.xie-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>\n" + "> >>>>Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>\n" "> >>>>---\n" "> >>>> drivers/mfd/88pm800.c | 19 +++++++++++++++++++\n" "> >>>> 1 file changed, 19 insertions(+)\n" @@ -48,24 +45,21 @@ "> >>>>index 8ea4467..34546a1 100644\n" "> >>>>--- a/drivers/mfd/88pm800.c\n" "> >>>>+++ b/drivers/mfd/88pm800.c\n" - "> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client=\n" - ",\n" + "> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client,\n" "> >>>> \t\t\treturn ret;\n" "> >>>> \t}\n" "> >>>>\n" "> >>>>+\t/*\n" - "> >>>>+\t * RTC in pmic can run even the core is powered off, and user can s=\n" - "et\n" + "> >>>>+\t * RTC in pmic can run even the core is powered off, and user can set\n" "> >>>>+\t * alarm in RTC. When the alarm is time out, the PMIC will power up\n" "> >>>>+\t * the core, and the whole system will boot up. When PMIC driver is\n" "> >>>>+\t * probed, it will read out some register to find out whether this\n" "> >>>>+\t * boot is caused by RTC timeout or not, and it need pass this\n" "> >>>>+\t * information to RTC driver.\n" - "> >>>>+\t * So we need rtc platform data to be existed to pass this informat=\n" - "ion.\n" + "> >>>>+\t * So we need rtc platform data to be existed to pass this information.\n" "> >>>>+\t */\n" "> >>>>+\tif (!pdata->rtc) {\n" - "> >>>>+\t\tpdata->rtc =3D devm_kzalloc(&client->dev,\n" + "> >>>>+\t\tpdata->rtc = devm_kzalloc(&client->dev,\n" "> >>>>+\t\t\t\t\t sizeof(*(pdata->rtc)), GFP_KERNEL);\n" "> >>>>+\t\tif (!pdata->rtc) {\n" "> >>>>+\t\t\tdev_err(&client->dev,\n" @@ -89,7 +83,7 @@ "> >>drivers/rtc/rtc-88pm800.c\t[sets the \"platform_data\" field]\n" "> >\n" "> >Then were is the platform_data field subsequently used?\n" - ">=20\n" + "> \n" "> Currently not used, but it is for future use, where we would be\n" "> interested to know that the wakeup is really from reset or RTC wakeup.\n" "\n" @@ -106,30 +100,21 @@ "> >};\n" "> >\n" "> >Is 'vrtc' even used? If so, where?\n" - ">=20\n" + "> \n" "> No, it is not.\n" "\n" "So either submit a patch-set that makes use of them, or let me know\n" "that you're not going to do that and I'll remove it altogether.\n" "Likewise for rtc_wakeup.\n" "\n" - "--=20\n" + "-- \n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org =E2=94=82 Open source software for ARM SoCs\n" + "Linaro.org \342\224\202 Open source software for ARM SoCs\n" "Follow Linaro: Facebook | Twitter | Blog\n" - "\n" - "--=20\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -603ed66d92fc38e06585169782b06f027969beb7c4ba2ebc3aeb896c4201297c +4e799e8b4488dec1011e32a23ab5e0239efc325df0fd07f6bf29b21361e58577
diff --git a/a/1.txt b/N3/1.txt index 3decd27..2830fb5 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -5,16 +5,12 @@ On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: > >>>On Sat, 30 May 2015, Vaibhav Hiremath wrote: > >>> > >>>>RTC in pmic 88PM800 can run even the core is powered off, and user -> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will powe= -r up -> >>>>the core, and the whole system will boot up. And during PMIC driver p= -robe, -> >>>>it will read some register to find out whether this boot is caused by= - RTC +> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will power up +> >>>>the core, and the whole system will boot up. And during PMIC driver probe, +> >>>>it will read some register to find out whether this boot is caused by RTC > >>>>timeout or not, and pass on this information to the RTC driver. > >>>> -> >>>>So we need rtc platform data to be existed in PMIC driver to pass thi= -s +> >>>>So we need rtc platform data to be existed in PMIC driver to pass this > >>>>information. > >>>> > >>>>Signed-off-by: Chao Xie <chao.xie@marvell.com> @@ -27,24 +23,21 @@ s > >>>>index 8ea4467..34546a1 100644 > >>>>--- a/drivers/mfd/88pm800.c > >>>>+++ b/drivers/mfd/88pm800.c -> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client= -, +> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client, > >>>> return ret; > >>>> } > >>>> > >>>>+ /* -> >>>>+ * RTC in pmic can run even the core is powered off, and user can s= -et +> >>>>+ * RTC in pmic can run even the core is powered off, and user can set > >>>>+ * alarm in RTC. When the alarm is time out, the PMIC will power up > >>>>+ * the core, and the whole system will boot up. When PMIC driver is > >>>>+ * probed, it will read out some register to find out whether this > >>>>+ * boot is caused by RTC timeout or not, and it need pass this > >>>>+ * information to RTC driver. -> >>>>+ * So we need rtc platform data to be existed to pass this informat= -ion. +> >>>>+ * So we need rtc platform data to be existed to pass this information. > >>>>+ */ > >>>>+ if (!pdata->rtc) { -> >>>>+ pdata->rtc =3D devm_kzalloc(&client->dev, +> >>>>+ pdata->rtc = devm_kzalloc(&client->dev, > >>>>+ sizeof(*(pdata->rtc)), GFP_KERNEL); > >>>>+ if (!pdata->rtc) { > >>>>+ dev_err(&client->dev, @@ -68,7 +61,7 @@ ion. > >>drivers/rtc/rtc-88pm800.c [sets the "platform_data" field] > > > >Then were is the platform_data field subsequently used? ->=20 +> > Currently not used, but it is for future use, where we would be > interested to know that the wakeup is really from reset or RTC wakeup. @@ -85,28 +78,15 @@ patch to that set and I can re-review it then. > >}; > > > >Is 'vrtc' even used? If so, where? ->=20 +> > No, it is not. So either submit a patch-set that makes use of them, or let me know that you're not going to do that and I'll remove it altogether. Likewise for rtc_wakeup. ---=20 +-- Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org =E2=94=82 Open source software for ARM SoCs +Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog - ---=20 ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N3/content_digest index de00228..66972e2 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -5,7 +5,7 @@ "ref\020150602074004.GH3329@x1\0" "ref\0556D71F6.4030608@linaro.org\0" "From\0Lee Jones <lee.jones@linaro.org>\0" - "Subject\0[rtc-linux] Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier\0" + "Subject\0Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier\0" "Date\0Tue, 2 Jun 2015 10:33:23 +0100\0" "To\0Vaibhav Hiremath <vaibhav.hiremath@linaro.org>\0" "Cc\0linux-arm-kernel@lists.infradead.org" @@ -26,16 +26,12 @@ "> >>>On Sat, 30 May 2015, Vaibhav Hiremath wrote:\n" "> >>>\n" "> >>>>RTC in pmic 88PM800 can run even the core is powered off, and user\n" - "> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will powe=\n" - "r up\n" - "> >>>>the core, and the whole system will boot up. And during PMIC driver p=\n" - "robe,\n" - "> >>>>it will read some register to find out whether this boot is caused by=\n" - " RTC\n" + "> >>>>can set alarm in RTC. When the alarm is timed out, the PMIC will power up\n" + "> >>>>the core, and the whole system will boot up. And during PMIC driver probe,\n" + "> >>>>it will read some register to find out whether this boot is caused by RTC\n" "> >>>>timeout or not, and pass on this information to the RTC driver.\n" "> >>>>\n" - "> >>>>So we need rtc platform data to be existed in PMIC driver to pass thi=\n" - "s\n" + "> >>>>So we need rtc platform data to be existed in PMIC driver to pass this\n" "> >>>>information.\n" "> >>>>\n" "> >>>>Signed-off-by: Chao Xie <chao.xie@marvell.com>\n" @@ -48,24 +44,21 @@ "> >>>>index 8ea4467..34546a1 100644\n" "> >>>>--- a/drivers/mfd/88pm800.c\n" "> >>>>+++ b/drivers/mfd/88pm800.c\n" - "> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client=\n" - ",\n" + "> >>>>@@ -586,6 +586,25 @@ static int pm800_probe(struct i2c_client *client,\n" "> >>>> \t\t\treturn ret;\n" "> >>>> \t}\n" "> >>>>\n" "> >>>>+\t/*\n" - "> >>>>+\t * RTC in pmic can run even the core is powered off, and user can s=\n" - "et\n" + "> >>>>+\t * RTC in pmic can run even the core is powered off, and user can set\n" "> >>>>+\t * alarm in RTC. When the alarm is time out, the PMIC will power up\n" "> >>>>+\t * the core, and the whole system will boot up. When PMIC driver is\n" "> >>>>+\t * probed, it will read out some register to find out whether this\n" "> >>>>+\t * boot is caused by RTC timeout or not, and it need pass this\n" "> >>>>+\t * information to RTC driver.\n" - "> >>>>+\t * So we need rtc platform data to be existed to pass this informat=\n" - "ion.\n" + "> >>>>+\t * So we need rtc platform data to be existed to pass this information.\n" "> >>>>+\t */\n" "> >>>>+\tif (!pdata->rtc) {\n" - "> >>>>+\t\tpdata->rtc =3D devm_kzalloc(&client->dev,\n" + "> >>>>+\t\tpdata->rtc = devm_kzalloc(&client->dev,\n" "> >>>>+\t\t\t\t\t sizeof(*(pdata->rtc)), GFP_KERNEL);\n" "> >>>>+\t\tif (!pdata->rtc) {\n" "> >>>>+\t\t\tdev_err(&client->dev,\n" @@ -89,7 +82,7 @@ "> >>drivers/rtc/rtc-88pm800.c\t[sets the \"platform_data\" field]\n" "> >\n" "> >Then were is the platform_data field subsequently used?\n" - ">=20\n" + "> \n" "> Currently not used, but it is for future use, where we would be\n" "> interested to know that the wakeup is really from reset or RTC wakeup.\n" "\n" @@ -106,30 +99,17 @@ "> >};\n" "> >\n" "> >Is 'vrtc' even used? If so, where?\n" - ">=20\n" + "> \n" "> No, it is not.\n" "\n" "So either submit a patch-set that makes use of them, or let me know\n" "that you're not going to do that and I'll remove it altogether.\n" "Likewise for rtc_wakeup.\n" "\n" - "--=20\n" + "-- \n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org =E2=94=82 Open source software for ARM SoCs\n" - "Follow Linaro: Facebook | Twitter | Blog\n" - "\n" - "--=20\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + "Linaro.org \342\224\202 Open source software for ARM SoCs\n" + Follow Linaro: Facebook | Twitter | Blog -603ed66d92fc38e06585169782b06f027969beb7c4ba2ebc3aeb896c4201297c +cb0fb826e9abe03dac49af4d0cecccaeefd178964cb89dc76b996562efc92a8c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.