All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Christoffer Holmstedt <christoffer@christofferholmstedt.se>,
	Varka Bhadram <varkabhadram@gmail.com>,
	linux-wpan@vger.kernel.org
Subject: Re: [PATCH wpan-tools] info: add frequency to channel listing for phy capabilities
Date: Tue, 2 Jun 2015 12:15:17 +0200	[thread overview]
Message-ID: <20150602101516.GD1977@omega> (raw)
In-Reply-To: <20150602093451.GF1897@wantstofly.org>

On Tue, Jun 02, 2015 at 12:34:51PM +0300, Lennert Buytenhek wrote:
> On Tue, Jun 02, 2015 at 09:38:27AM +0200, Christoffer Holmstedt wrote:
> 
> > > > This is for the same reason as above. Alignment in the output, it is a trade
> > > > off between "readability" in two different ways. Alignment in the output or
> > > > printing the full word "Unknown". I will change this to "Unknown" and we can
> > > > change it at a later date if it ever shows up and mess up alignment. In any
> > > > case if "Unknown" shows up the actual frequency should be added instead of
> > > > fixing alignment. ;)
> > > > 
> > > 
> > > Then maybe some "-" instead "unkown", is this better, or it's too small
> > > then?
> > > 
> > 
> > The more I think about it the more I feel "Unknown" is better. If for some
> > reason the channel page and channel combination is not listed and "Unknown" is
> > printed the last thing the user will care about is alignment in the output.
> > 
> > Channel page and channel number information will not change that often
> > so we should be able to keep up with future changes (additions). I have
> > tried to get hold of the 802.15.4-2015 draft from March/April but
> > without success. The local university will charge me ~350€ or something
> > in that region for it. I wanted it to see if any new channel
> > pages/channels have been added since -2011 edition.
> 
> There are some amendments already available for download that
> document new channel pages:
> 
> 802.15.4f-2012.pdf: channel pages 7, 8
> 802.15.4g-2012.pdf: channel pages 9, 10
> 802.15.4j-2013.pdf: channel page 11
> 802.15.4k-2013.pdf: channel page 12
> 802.15.4p-2014.pdf: channel page 13

mhhh, I looked into this. At the moment we have a highest channel number
define (don't asking me where this comes from, was before there) [0]. I
thought somewhere from the standard, that's why it's inside
ieee802154.h.

I see for example 802.15.4k-2013 that the "phyCurrentChannel" range is
above of them. e.g. Table 681. Currently we save it in some array file
and the current channel is a bitfield [1].

So I think if we support it in kernel, we need some more granularity
representation of the channels/pages, maybe also introduce some enums
about band identifier information and such things.

I want to note that only.


The current nl802154 for asking supported channel/page should be easily
extendable since we doing for_each_nested stuff there. But Currently there
is a lack of support for channel/page stuff, the datatype is also "u8" and
seems also to be something which fits not in there like "current channel
range: 1-416".

Oh well, that would be fun to change it again. :-)

- Alex

[0] http://lxr.free-electrons.com/source/include/linux/ieee802154.h#L42
[1] http://lxr.free-electrons.com/source/include/net/cfg802154.h#L85

  parent reply	other threads:[~2015-06-02 10:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 13:35 [PATCH wpan-tools] info: add frequency to channel listing for phy capabilities Christoffer Holmstedt
2015-06-02  4:10 ` Varka Bhadram
2015-06-02  6:08   ` Christoffer Holmstedt
2015-06-02  7:09     ` Alexander Aring
2015-06-02  7:38       ` Christoffer Holmstedt
2015-06-02  9:34         ` Lennert Buytenhek
2015-06-02  9:53           ` Christoffer Holmstedt
2015-06-02 10:15           ` Alexander Aring [this message]
2015-06-02 10:37             ` Lennert Buytenhek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150602101516.GD1977@omega \
    --to=alex.aring@gmail.com \
    --cc=buytenh@wantstofly.org \
    --cc=christoffer@christofferholmstedt.se \
    --cc=linux-wpan@vger.kernel.org \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.