From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, laijs@cn.fujitsu.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] rcu: Use WRITE_ONCE in RCU_INIT_POINTER
Date: Tue, 2 Jun 2015 09:25:44 -0700 [thread overview]
Message-ID: <20150602162544.GI5989@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150602152648.GT3644@twins.programming.kicks-ass.net>
On Tue, Jun 02, 2015 at 05:26:48PM +0200, Peter Zijlstra wrote:
>
> For the paranoid amongst us GCC would be in its right to use byte stores
> to write our NULL value, tell it not to do that.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Good point, queued for 4.3.
Thanx, Paul
> ---
> include/linux/rcupdate.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index 33a056bb886f..e173847b6543 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -1046,7 +1046,7 @@ static inline notrace void rcu_read_unlock_sched_notrace(void)
> #define RCU_INIT_POINTER(p, v) \
> do { \
> rcu_dereference_sparse(p, __rcu); \
> - p = RCU_INITIALIZER(v); \
> + WRITE_ONCE(p, RCU_INITIALIZER(v)); \
> } while (0)
>
> /**
>
prev parent reply other threads:[~2015-06-02 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 15:26 [RFC][PATCH] rcu: Use WRITE_ONCE in RCU_INIT_POINTER Peter Zijlstra
2015-06-02 16:25 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602162544.GI5989@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.