From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:31817 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbbFCBfw (ORCPT ); Tue, 2 Jun 2015 21:35:52 -0400 Date: Wed, 3 Jun 2015 11:35:23 +1000 From: Dave Chinner To: gregkh@linuxfoundation.org Cc: dchinner@redhat.com, bfoster@redhat.com, stable@vger.kernel.org, stable-commits@vger.kernel.org Subject: Re: Patch "xfs: xfs_iozero can return positive errno" has been added to the 3.14-stable tree Message-ID: <20150603013523.GE9143@dastard> References: <1433293975206201@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433293975206201@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jun 03, 2015 at 10:12:55AM +0900, gregkh@linuxfoundation.org wrote: > > This is a note to let you know that I've just added the patch titled > > xfs: xfs_iozero can return positive errno > > to the 3.14-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > xfs-xfs_iozero-can-return-positive-errno.patch > and it can be found in the queue-3.14 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, No, it shouldn't be applied to 3.14, because: > From cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 Mon Sep 17 00:00:00 2001 > From: Dave Chinner > Date: Fri, 29 May 2015 07:40:32 +1000 > Subject: xfs: xfs_iozero can return positive errno > > From: Dave Chinner > > commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream. > > It was missed when we converted everything in XFs to use negative error > numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global ^^^^^^^^^^^^^^^^^^^^^^ The upstream commit also had an indication of what stable kernels it needed to be applied to. i.e: cc: # 3.17, 3.18, 3.19, 4.0 Cheers, Dave. -- Dave Chinner david@fromorbit.com