All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: umgwanakikbuti@gmail.com, mingo@elte.hu, ktkhai@parallels.com,
	rostedt@goodmis.org, juri.lelli@gmail.com,
	pang.xunlei@linaro.org, oleg@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 7/7] sched,dl: Convert switched_{from,to}_dl() / prio_changed_dl() to balance callbacks
Date: Wed, 3 Jun 2015 10:22:57 +0530	[thread overview]
Message-ID: <20150603045256.GB1545@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150601140840.270836867@infradead.org>

* Peter Zijlstra <peterz@infradead.org> [2015-06-01 15:58:25]:

[...]

>  
> -static DEFINE_PER_CPU(struct callback_head, dl_balance_head);
> +static DEFINE_PER_CPU(struct callback_head, dl_push_head);
> +static DEFINE_PER_CPU(struct callback_head, dl_pull_head);
>  
>  static void push_dl_tasks(struct rq *);
> +static void pull_dl_task(struct rq *);
>  
>  static inline void queue_push_tasks(struct rq *rq)
>  {
>  	if (!has_pushable_dl_tasks(rq))
>  		return;
>  
> -	queue_balance_callback(rq, &per_cpu(dl_balance_head, rq->cpu), push_dl_tasks);
> +	queue_balance_callback(rq, &per_cpu(dl_push_head, rq->cpu), push_dl_tasks);
> +}
> +
> +static inline void queue_pull_task(struct rq *rq)
> +{
> +	queue_balance_callback(rq, &per_cpu(dl_pull_head, rq->cpu), pull_dl_task);
>  }

queue_pull_task() is not defined for CONFIG_SMP=n case, following build error
is seen while building the kernel with SMP=n:

  CC      kernel/sched/deadline.o
kernel/sched/deadline.c: In function ‘switched_from_dl’:
kernel/sched/deadline.c:1713:2: error: implicit declaration of function ‘queue_pull_task’ [-Werror=implicit-function-declaration]
  queue_pull_task(rq);
  ^
cc1: some warnings being treated as errors

Thanks,
Kamalesh.


  reply	other threads:[~2015-06-03  4:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 13:58 [RFC][PATCH 0/7] sched: balance callbacks Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 1/7] sched: Replace post_schedule with a balance callback list Peter Zijlstra
2015-06-03  4:41   ` Kamalesh Babulal
2015-06-03  7:21     ` Peter Zijlstra
2015-06-03  8:24   ` pang.xunlei
2015-06-03  8:55     ` Peter Zijlstra
2015-06-05  7:13       ` pang.xunlei
2015-06-05  7:19         ` Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 2/7] sched: Use replace normalize_task() with __sched_setscheduler() Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 3/7] sched: Allow balance callbacks for check_class_changed() Peter Zijlstra
2015-06-02 13:58   ` Kirill Tkhai
2015-06-02 14:27     ` Peter Zijlstra
2015-06-02 16:07       ` Peter Zijlstra
2015-06-02 16:27         ` Kirill Tkhai
2015-06-03  7:32           ` Peter Zijlstra
2015-06-03 10:40             ` Kirill Tkhai
2015-06-03 10:42             ` Kirill Tkhai
2015-06-03 10:45               ` Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 4/7] sched,rt: Remove return value from pull_rt_task() Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 5/7] sched,rt: Convert switched_{from,to}_rt() / prio_changed_rt() to balance callbacks Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 6/7] sched,dl: Remove return value from pull_dl_task() Peter Zijlstra
2015-06-01 13:58 ` [RFC][PATCH 7/7] sched,dl: Convert switched_{from,to}_dl() / prio_changed_dl() to balance callbacks Peter Zijlstra
2015-06-03  4:52   ` Kamalesh Babulal [this message]
2015-06-01 14:16 ` [RFC][PATCH 0/7] sched: " Peter Zijlstra
2015-06-01 14:42 ` Mike Galbraith
2015-06-02  6:48   ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150603045256.GB1545@linux.vnet.ibm.com \
    --to=kamalesh@linux.vnet.ibm.com \
    --cc=juri.lelli@gmail.com \
    --cc=ktkhai@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=pang.xunlei@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.