All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH][meta-oe] php: add a vardeps for configure on sysconfdir
Date: Wed, 3 Jun 2015 12:11:38 +0200	[thread overview]
Message-ID: <20150603101138.GA2380@jama> (raw)
In-Reply-To: <1433324376-3374-1-git-send-email-rongqing.li@windriver.com>

On Wed, Jun 03, 2015 at 05:39:36PM +0800, rongqing.li@windriver.com wrote:
> From: Roy Li <rongqing.li@windriver.com>
> 
> building php will fail when sstatus is used, since some hardcode paths

what's sstatus? did you mean sstate?

> in php-native will make the wrong path, and try to fix it like below:
>     do_install_append_virtclass-native() {
>            create_wrapper ${D}${bindir}/php \
>                PHP_PEAR_SYSCONF_DIR=${sysconfdir}/ \
>     }
> but php-native does not work for a 64bit target(qemuarm64) and if sstat is
> from a 32bit(qemuppc) on the host same machine.
> 
> Consider no too much package depends on php-native, so add a vardeps for
> configure on sysconfdir to force php-native to build always.

Please improve the commit message, from this I'm still not sure what
this is supposed to fix.

> 
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
>  meta-oe/recipes-devtools/php/php_5.5.24.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-oe/recipes-devtools/php/php_5.5.24.bb b/meta-oe/recipes-devtools/php/php_5.5.24.bb
> index 3e656af..9c0dd7f 100644
> --- a/meta-oe/recipes-devtools/php/php_5.5.24.bb
> +++ b/meta-oe/recipes-devtools/php/php_5.5.24.bb
> @@ -106,6 +106,8 @@ EXTRA_OEMAKE = "INSTALL_ROOT=${D}"
>  
>  acpaths = ""
>  
> +do_configure[vardeps] += "${sysconfdir}"
> +
>  do_configure_prepend () {
>      rm -f ${S}/build/libtool.m4 ${S}/ltmain.sh ${S}/aclocal.m4
>      find ${S} -name config.m4 | xargs -n1 sed -i 's!APXS_HTTPD=.*!APXS_HTTPD=${STAGING_BINDIR_NATIVE}/httpd!'
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


  reply	other threads:[~2015-06-03 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03  9:39 [PATCH][meta-oe] php: add a vardeps for configure on sysconfdir rongqing.li
2015-06-03 10:11 ` Martin Jansa [this message]
2015-06-03 13:09   ` Rongqing Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150603101138.GA2380@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.