From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344AbbFCPPG (ORCPT ); Wed, 3 Jun 2015 11:15:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37454 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933312AbbFCPO5 (ORCPT ); Wed, 3 Jun 2015 11:14:57 -0400 Date: Wed, 3 Jun 2015 17:14:50 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Peter Zijlstra , Paul Mackerras , David Ahern , Namhyung Kim , Ingo Molnar , Andi Kleen , Stephane Eranian Subject: Re: [PATCH 4/9] perf stat: Remove transaction_run from shadow update/print code Message-ID: <20150603151450.GA1246@krava.redhat.com> References: <1433341559-31848-1-git-send-email-jolsa@kernel.org> <1433341559-31848-5-git-send-email-jolsa@kernel.org> <20150603151038.GX624@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150603151038.GX624@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2015 at 12:10:38PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 03, 2015 at 04:25:54PM +0200, Jiri Olsa escreveu: > > It's no longer needed, because we use nameid to recognize > > transaction events. > > > > Keeping it only in stat code to initialize transaction events. > > Lemme see if I understand this correctly, this update_shadow_stats() is > called only for transaction runs? > > It doesn't seem so, so now we will update those stats all the time? update_shadow_stats is called on currently read/processed counter and based on its 'type' we update various other counters - shadow counters - which are the base for things like IPC in the stat output jirka