diff for duplicates of <20150603171923.GA3402@localhost.localdomain> diff --git a/a/1.txt b/N1/1.txt index c26e4f0..96ee7d8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -63,7 +63,7 @@ On Wed, Jun 03, 2015 at 01:54:01PM -0300, mleitner@redhat.com wrote: > + > + spin_lock_bh(&net->sctp.addr_wq_lock); > + list_for_each_entry_rcu(temp, &net->sctp.addr_waitq, list) { -> + if (temp = addrw) { +> + if (temp == addrw) { > + list_del_rcu(&addrw->list); > + kfree_rcu(addrw, rcu); @@ -140,7 +140,7 @@ Missed a break here, will issue a v3 when you review it too.. > + list_for_each_entry_rcu(addrw, &net->sctp.addr_waitq, list) { > if (addrw->a.sa.sa_family != addr->a.sa.sa_family) > continue; -> if (addrw->a.sa.sa_family = AF_INET) { +> if (addrw->a.sa.sa_family == AF_INET) { > @@ -702,7 +720,7 @@ void sctp_addr_wq_mgmt(struct net *net, struct sctp_sockaddr_entry *addr, int cm > * new address after a couple of addition and deletion of that address > */ @@ -167,7 +167,7 @@ Missed a break here, will issue a v3 when you review it too.. > > /* OK, we have to add the new address to the wait queue */ > addrw = kmemdup(addr, sizeof(struct sctp_sockaddr_entry), GFP_ATOMIC); -> - if (addrw = NULL) { +> - if (addrw == NULL) { > - spin_unlock_bh(&net->sctp.addr_wq_lock); > + if (!addrw) > return; diff --git a/a/content_digest b/N1/content_digest index 0d08bb7..0d5dff6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0660872d4d795833eca5f7e517c7e1dabbc1df02b.1433350421.git.marcelo.leitner@gmail.com\0" "From\0Marcelo Ricardo Leitner <mleitner@redhat.com>\0" "Subject\0Re: [PATCH v2 1/2] sctp: rcu-ify addr_waitq\0" - "Date\0Wed, 03 Jun 2015 17:19:23 +0000\0" + "Date\0Wed, 3 Jun 2015 14:19:23 -0300\0" "To\0Neil Horman <nhorman@tuxdriver.com>" " netdev@vger.kernel.org\0" "Cc\0linux-sctp@vger.kernel.org" @@ -76,7 +76,7 @@ "> +\n" "> +\tspin_lock_bh(&net->sctp.addr_wq_lock);\n" "> +\tlist_for_each_entry_rcu(temp, &net->sctp.addr_waitq, list) {\n" - "> +\t\tif (temp = addrw) {\n" + "> +\t\tif (temp == addrw) {\n" "> +\t\t\tlist_del_rcu(&addrw->list);\n" "> +\t\t\tkfree_rcu(addrw, rcu);\n" "\n" @@ -153,7 +153,7 @@ "> +\tlist_for_each_entry_rcu(addrw, &net->sctp.addr_waitq, list) {\n" "> \t\tif (addrw->a.sa.sa_family != addr->a.sa.sa_family)\n" "> \t\t\tcontinue;\n" - "> \t\tif (addrw->a.sa.sa_family = AF_INET) {\n" + "> \t\tif (addrw->a.sa.sa_family == AF_INET) {\n" "> @@ -702,7 +720,7 @@ void sctp_addr_wq_mgmt(struct net *net, struct sctp_sockaddr_entry *addr, int cm\n" "> \t * new address after a couple of addition and deletion of that address\n" "> \t */\n" @@ -180,7 +180,7 @@ "> \n" "> \t/* OK, we have to add the new address to the wait queue */\n" "> \taddrw = kmemdup(addr, sizeof(struct sctp_sockaddr_entry), GFP_ATOMIC);\n" - "> -\tif (addrw = NULL) {\n" + "> -\tif (addrw == NULL) {\n" "> -\t\tspin_unlock_bh(&net->sctp.addr_wq_lock);\n" "> +\tif (!addrw)\n" "> \t\treturn;\n" @@ -202,4 +202,4 @@ "> More majordomo info at http://vger.kernel.org/majordomo-info.html\n" > -8134d6f29c3bdbf79f63c862f4def34ce27977619ac2dcfb6bea81d31ac496e5 +688f6dd7cc82c667b8af8fce7530fa8e2b4514e718fad772c15b25e7fa33bc65
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.