From: Thomas Huth <thuth@redhat.com>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de,
mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH v6 4/6] spapr_pci: set device node unit address as hex
Date: Wed, 3 Jun 2015 19:23:39 +0200 [thread overview]
Message-ID: <20150603192339.05a6f5e7@thh440s> (raw)
In-Reply-To: <1433330757-6043-5-git-send-email-nikunj@linux.vnet.ibm.com>
On Wed, 3 Jun 2015 16:55:55 +0530
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> wrote:
> Device node names should encode the unit address as hex, while the
> code was encodind it as integers.
>
> Also, use FDT_NAME_MAX macro for allocating and composing the name.
>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
> hw/ppc/spapr_pci.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2015-06-03 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 11:25 [Qemu-devel] [PATCH v6 0/6] spapr_pci: DT field fixes and PCI DT node creation in QEMU Nikunj A Dadhania
2015-06-03 11:25 ` [Qemu-devel] [PATCH v6 1/6] spapr_pci: encode missing 64-bit memory address space Nikunj A Dadhania
2015-06-03 11:25 ` [Qemu-devel] [PATCH v6 2/6] spapr_pci: encode class code including Prog IF register Nikunj A Dadhania
2015-06-03 11:25 ` [Qemu-devel] [PATCH v6 3/6] spapr_pci: enumerate and add PCI device tree Nikunj A Dadhania
2015-06-03 11:25 ` [Qemu-devel] [PATCH v6 4/6] spapr_pci: set device node unit address as hex Nikunj A Dadhania
2015-06-03 17:23 ` Thomas Huth [this message]
2015-06-03 11:25 ` [Qemu-devel] [PATCH v6 5/6] spapr_pci: populate ibm,loc-code Nikunj A Dadhania
2015-06-03 17:40 ` Thomas Huth
2015-06-04 5:16 ` Nikunj A Dadhania
2015-06-03 11:25 ` [Qemu-devel] [PATCH v6 6/6] spapr_pci: drop redundant args in spapr_populate_pci_child_dt Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603192339.05a6f5e7@thh440s \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=mdroth@linux.vnet.ibm.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.