From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752093AbbFDGJY (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Jun 2015 02:09:24 -0400
Received: from mail-wi0-f173.google.com ([209.85.212.173]:35024 "EHLO
	mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751364AbbFDGJS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Jun 2015 02:09:18 -0400
Date: Thu, 4 Jun 2015 08:09:12 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Borislav Petkov <bp@alien8.de>, LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org,
        David Howells <dhowells@redhat.com>, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] x86/asm/msr: Retract msr-index.h
Message-ID: <20150604060912.GA14159@gmail.com>
References: <1433335308-27114-1-git-send-email-bp@alien8.de>
 <20150603182134.GR4403@pd.tnic>
 <556F4DE1.8070706@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <556F4DE1.8070706@zytor.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 06/03/2015 11:21 AM, Borislav Petkov wrote:
> > On Wed, Jun 03, 2015 at 02:41:48PM +0200, Borislav Petkov wrote:
> >> This header containing all MSRs and respective bit definitions got
> >> exported to userspace in conjunction with the big uapi shuffle.
> >>
> >> But, it doesn't have anything to do in the uapi headers because
> >> userspace can do its own MSR defines and exporting them from the
> >> kernel blocks us from doing cleanups/renames in that header. Which is
> >> ridiculous - it is not kernel's job to export such a header and keep
> >> MSRs list and their names stable.
> > 
> > Here's v2. Needed to *not* include it into uapi/asm/msr.h either.
> 
> I really like the patch, but the description is awful.
> 
> How about: "x86/uapi: <asm/msr.h> is not a UAPI"

So a small nit: a simple statement of fact is not really a proper commit title.
A commit title should express what the patch _does_.

Missing leading verbs are really passive-aggressive on the reader of a flow of 
commit titles - such as when reading a short log or a one-line git log.

Something like:

	x86/uapi: Remove <asm/msr.h> from the list of exported UAPI headers

or so would work fine with me.

Thanks!

	Ingo