Re: [PATCH wpan-tools] interface: fix interface type info

[Alexander Aring <alex.aring@gmail.com>]

On Wed, Jun 03, 2015 at 11:21:38AM +0530, Varka Bhadram wrote:
> 
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
>  src/interface.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/interface.c b/src/interface.c
> index e501763..1c59876 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -28,7 +28,7 @@ const char *iftype_name(enum nl802154_iftype iftype)
>  	case NL802154_IFTYPE_COORD:
>  		return "coordinator";
>  	default:
> -		sprintf(modebuf, "Unknown mode (%d)", iftype);
> +		sprintf(modebuf, "Invalid iftype (%d)", iftype);
>  		return modebuf;

This error message is like iw tool. I don't know how we strict we should
make the behaviour like wireless here. I think it's okay to change that.

But note there is also a "modebuf" and you changed "Unknown mode ..." to
"Unknown iftype..." if you want to change it then I would assume to make
everything to "iftypeFOOBAR". I mean change "modebuf" to "iftypebuf" or
something else.

I can understand "Unknown mode" is confusing. But to handle now "iftypeFOO"
and "modeFOO" is more confusing than before.

- Alex