All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: linux-wpan@vger.kernel.org, Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH bluetooth-next] nl802154: export supported commands
Date: Thu, 4 Jun 2015 09:30:27 +0200	[thread overview]
Message-ID: <20150604073023.GB13133@omega> (raw)
In-Reply-To: <1433304841-12734-1-git-send-email-varkab@cdac.in>

On Wed, Jun 03, 2015 at 09:44:01AM +0530, Varka Bhadram wrote:
> This patch will export the supported commands by the devices
> to the user. This is required because user should know supported
> commands by the IEEE-802.15.4 devices. Drivers that are there in
> the mainline are not supporting all the functionalities that the
> core is providing to us.
> 
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
>  include/net/nl802154.h    |    2 ++
>  net/ieee802154/nl802154.c |   36 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+)
> 
> diff --git a/include/net/nl802154.h b/include/net/nl802154.h
> index 0badebd..6fc231e 100644
> --- a/include/net/nl802154.h
> +++ b/include/net/nl802154.h
> @@ -102,6 +102,8 @@ enum nl802154_attrs {
>  
>  	NL802154_ATTR_WPAN_PHY_CAPS,
>  
> +	NL802154_ATTR_SUPPORTED_COMMANDS,
> +
>  	/* add attributes here, update the policy in nl802154.c */
>  

for your v2, please also note the comment here "update the policy in
nl802154.c".

This means you need to add:

diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index 310a519..a6ae29d 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -228,6 +228,8 @@ static const struct nla_policy nl802154_policy[NL802154_ATTR_MAX+1] = {
        [NL802154_ATTR_LBT_MODE] = { .type = NLA_U8, },
 
        [NL802154_ATTR_WPAN_PHY_CAPS] = { .type = NLA_NESTED },
+
+       [NL802154_ATTR_SUPPORTED_COMMANDS] = { .type = NLA_NESTED },
 };
 
 /* message building helper */


- Alex

  parent reply	other threads:[~2015-06-04  7:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03  4:14 [PATCH bluetooth-next] nl802154: export supported commands Varka Bhadram
2015-06-03  6:49 ` Alexander Aring
2015-06-03  7:13   ` Varka Bhadram
2015-06-03  7:48     ` Alexander Aring
2015-06-04  7:30 ` Alexander Aring [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-06-03  4:09 Varka Bhadram
2015-06-03  4:12 ` Varka Bhadram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150604073023.GB13133@omega \
    --to=alex.aring@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=varkab@cdac.in \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.