Re: [PATCH] soc/tegra: fuse: fix build break due to missing linux/module.h include

[Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]

On Thu, Jun 04, 2015 at 07:28:48AM +0000, Paul Walmsley wrote:
> 
> tegra_defconfig builds are broken on next-20150603:
> 
> ----
> drivers/soc/tegra/fuse/fuse-tegra.c:171:1: warning: data definition has no type or storage class [enabled by default]
> drivers/soc/tegra/fuse/fuse-tegra.c:171:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
> drivers/soc/tegra/fuse/fuse-tegra.c:171:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/soc/tegra/fuse/fuse-tegra.c:171:1: warning: data definition has no type or storage class [enabled by default]
> drivers/soc/tegra/fuse/fuse-tegra.c:171:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
> drivers/soc/tegra/fuse/fuse-tegra.c:171:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/soc/tegra/fuse/fuse-tegra.c:171:1: warning: 'tegra_fuse_driver_init' defined but not used [-Wunused-function]
> ----
> 
> This is due to the intersection of commit
> 436b6428b9cc97f61721f335eb9d8010751a337e ("soc/tegra: fuse: Unify
> Tegra20 and Tegra30 drivers") and commit
> 5ebbb3badaa8ffc50558af88cdea27497953356a ("module: relocate
> module_init from init.h to module.h") in the linux-next tree.
> 
> Fix by replacing the linux/kernel.h include in
> drivers/soc/tegra/fuse/fuse-tegra.c with a linux/module.h include.
> 
> Signed-off-by: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
> Cc: Paul Walmsley <pwalmsley-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Cc: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Cc: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I've squashed this into the offending commit, thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]