From: Peter Zijlstra <peterz@infradead.org>
To: Imre Palik <imrep.amz@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Paul Mackerras <paulus@samba.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, "Palik, Imre" <imrep@amazon.de>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [RFC PATCH] perf: honoring cpuid for number of fixed counters
Date: Thu, 4 Jun 2015 13:49:17 +0200 [thread overview]
Message-ID: <20150604114917.GI3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <557029DC.6080201@gmail.com>
On Thu, Jun 04, 2015 at 12:35:08PM +0200, Imre Palik wrote:
> On 06/03/15 10:36, Peter Zijlstra wrote:
> > Further, the Intel Arch PerfMon v2 spec actually specifies there to be 3
> > fixed function counters.
> >
> > So anything that says it is v2+ and does not have the 3, is non
> > compliant.
> >
> > I would suggest you go fix your hypervisor.
>
> If I set up the hypervisor to advertise Arch PerfMon v1 (0 fixed
> counters), then without my patch, perf still tries to use fixed
> counters. So something is clearly broken here.
So the code you deleted does if (version > 1), and last I checked that
should return false if version == 1.
So please check what's happening there first.
next prev parent reply other threads:[~2015-06-04 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 8:03 [RFC PATCH] perf: honoring cpuid for number of fixed counters Imre Palik
2015-06-03 8:36 ` Peter Zijlstra
2015-06-04 10:35 ` Imre Palik
2015-06-04 11:49 ` Peter Zijlstra [this message]
2015-06-04 12:30 ` Imre Palik
2015-06-04 13:29 ` Peter Zijlstra
2015-06-05 13:02 ` Imre Palik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604114917.GI3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=aliguori@amazon.com \
--cc=hpa@zytor.com \
--cc=imrep.amz@gmail.com \
--cc=imrep@amazon.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.