From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/8] staging : wilc1000 : remove WILC_Sint8
Date: Thu, 04 Jun 2015 14:03:10 +0000 [thread overview]
Message-ID: <20150604140310.GI28762@mwanda> (raw)
In-Reply-To: <1433307037-30716-1-git-send-email-chaehyun.lim@gmail.com>
On Wed, Jun 03, 2015 at 01:50:37PM +0900, chaehyun lim wrote:
> -static WILC_Sint8 *gps8ConfigPacket;
> +static s8 *gps8ConfigPacket;
It's so unusual to use s8 that it raises suspiciouns... We eventually
cast gps8ConfigPacket to char and use it to store u8 values.
TODO: wilc1000: fix ps8packet type.
regards,
dan carpenter
prev parent reply other threads:[~2015-06-04 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 4:50 [PATCH 5/8] staging : wilc1000 : remove WILC_Sint8 chaehyun lim
2015-06-03 7:18 ` walter harms
2015-06-04 14:03 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604140310.GI28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.