All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Zviagintsev <sergei@s15v.net>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Daniel Mack <daniel@zonque.org>,
	David Herrmann <dh.herrmann@googlemail.com>,
	Djalal Harouni <tixxdz@opendz.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	sergei@s15v.net
Subject: Re: [PATCH] kdbus: fix type conversion in item macroses
Date: Thu, 4 Jun 2015 18:24:26 +0300	[thread overview]
Message-ID: <20150604152426.GH4549@localhost.localdomain> (raw)
In-Reply-To: <CANq1E4TkyBiJQuZG5Qt810176Be6==RxD4AWsw41TbKZ7d8dLw@mail.gmail.com>

Hi,

On Thu, Jun 04, 2015 at 01:26:03PM +0200, David Herrmann wrote:
> Hi
> 
> On Thu, Jun 4, 2015 at 12:39 PM, Sergei Zviagintsev <sergei@s15v.net> wrote:
> > KDBUS_ITEM_NEXT and KDBUS_ITEMS_END macroses do not enclose _i argument
> > into parentheses when applying the cast operator. If complex expression
> > passed, e.g.
> >
> >     KDBUS_ITEM_NEXT(condition ? a : b)
> >
> > then type conversion to (u8 *) will go wrong due to precedence rules.
> >
> > Use parentheses properly. Update documentation.
> >
> > Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
> > ---
> >  Documentation/kdbus/kdbus.item.xml | 2 +-
> >  ipc/kdbus/item.h                   | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

It seems that I missed the same issue with KDBUS_ITEMS_SIZE (and
samples/kdbus as well, but that would be another patch), so I'd better
fix that and merge with updated version of

  http://permalink.gmane.org/gmane.linux.kernel/1969533

into single patch.

  reply	other threads:[~2015-06-04 15:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 10:39 [PATCH] kdbus: fix type conversion in item macroses Sergei Zviagintsev
2015-06-04 11:26 ` David Herrmann
2015-06-04 15:24   ` Sergei Zviagintsev [this message]
2015-06-04 11:49 ` Frans Klaver
2015-06-04 12:17   ` Sergei Zviagintsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150604152426.GH4549@localhost.localdomain \
    --to=sergei@s15v.net \
    --cc=daniel@zonque.org \
    --cc=dh.herrmann@gmail.com \
    --cc=dh.herrmann@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tixxdz@opendz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.