All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Matthijs van Duin <matthijsvanduin@gmail.com>,
	Mike Turquette <mturquette@linaro.org>,
	Paul Walmsley <paul@pwsan.com>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 05/12] ARM: OMAP2+: Add support for initializing dm814x clocks
Date: Thu, 4 Jun 2015 11:42:54 -0700	[thread overview]
Message-ID: <20150604184254.GJ490@codeaurora.org> (raw)
In-Reply-To: <1433348601-8966-6-git-send-email-tony@atomide.com>

On 06/03, Tony Lindgren wrote:
> diff --git a/drivers/clk/ti/clk-814x.c b/drivers/clk/ti/clk-814x.c
> new file mode 100644
> index 0000000..bd2353c
> --- /dev/null
> +++ b/drivers/clk/ti/clk-814x.c
> @@ -0,0 +1,36 @@
> +/*
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/list.h>

Is list.h used?

> +#include <linux/clk-provider.h>
> +#include <linux/clk/ti.h>
> +
> +static struct ti_dt_clk dm814_clks[] = {
> +	DT_CLK(NULL, "devosc_ck", "devosc_ck"),
> +	DT_CLK(NULL, "mpu_ck", "mpu_ck"),
> +	DT_CLK(NULL, "sysclk4_ck", "sysclk4_ck"),
> +	DT_CLK(NULL, "sysclk6_ck", "sysclk6_ck"),
> +	DT_CLK(NULL, "sysclk10_ck", "sysclk10_ck"),
> +	DT_CLK(NULL, "sysclk18_ck", "sysclk18_ck"),
> +	DT_CLK(NULL, "timer_sys_ck", "devosc_ck"),
> +	DT_CLK(NULL, "cpsw_125mhz_gclk", "cpsw_125mhz_gclk"),
> +	DT_CLK(NULL, "cpsw_cpts_rft_clk", "cpsw_cpts_rft_clk"),
> +	{ .node_name = NULL },
> +};
> +
> +static const char *enable_init_clks[] = {
> +};

delete?

> +
> +int __init dm814x_dt_clk_init(void)
> +{
> +	ti_dt_clocks_register(dm814_clks);
> +	omap2_clk_disable_autoidle_all();
> +	omap2_clk_enable_init_clocks(enable_init_clks,
> +				     ARRAY_SIZE(enable_init_clks));

And pass NULL and 0 here?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/12] ARM: OMAP2+: Add support for initializing dm814x clocks
Date: Thu, 4 Jun 2015 11:42:54 -0700	[thread overview]
Message-ID: <20150604184254.GJ490@codeaurora.org> (raw)
In-Reply-To: <1433348601-8966-6-git-send-email-tony@atomide.com>

On 06/03, Tony Lindgren wrote:
> diff --git a/drivers/clk/ti/clk-814x.c b/drivers/clk/ti/clk-814x.c
> new file mode 100644
> index 0000000..bd2353c
> --- /dev/null
> +++ b/drivers/clk/ti/clk-814x.c
> @@ -0,0 +1,36 @@
> +/*
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/list.h>

Is list.h used?

> +#include <linux/clk-provider.h>
> +#include <linux/clk/ti.h>
> +
> +static struct ti_dt_clk dm814_clks[] = {
> +	DT_CLK(NULL, "devosc_ck", "devosc_ck"),
> +	DT_CLK(NULL, "mpu_ck", "mpu_ck"),
> +	DT_CLK(NULL, "sysclk4_ck", "sysclk4_ck"),
> +	DT_CLK(NULL, "sysclk6_ck", "sysclk6_ck"),
> +	DT_CLK(NULL, "sysclk10_ck", "sysclk10_ck"),
> +	DT_CLK(NULL, "sysclk18_ck", "sysclk18_ck"),
> +	DT_CLK(NULL, "timer_sys_ck", "devosc_ck"),
> +	DT_CLK(NULL, "cpsw_125mhz_gclk", "cpsw_125mhz_gclk"),
> +	DT_CLK(NULL, "cpsw_cpts_rft_clk", "cpsw_cpts_rft_clk"),
> +	{ .node_name = NULL },
> +};
> +
> +static const char *enable_init_clks[] = {
> +};

delete?

> +
> +int __init dm814x_dt_clk_init(void)
> +{
> +	ti_dt_clocks_register(dm814_clks);
> +	omap2_clk_disable_autoidle_all();
> +	omap2_clk_enable_init_clocks(enable_init_clks,
> +				     ARRAY_SIZE(enable_init_clks));

And pass NULL and 0 here?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-06-04 18:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 16:23 [PATCH 00/12] Minimal support for dm814x-evm and hp t410 thin client Tony Lindgren
2015-06-03 16:23 ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 01/12] ARM: OMAP2+: Fix dm814x DT_MACHINE_START Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 02/12] ARM: OMAP2+: Fix scrm compatible for dm814x Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 19:08   ` Sergei Shtylyov
2015-06-03 19:08     ` Sergei Shtylyov
2015-06-03 19:38     ` Tony Lindgren
2015-06-03 19:38       ` Tony Lindgren
2015-07-16  9:11       ` Tony Lindgren
2015-07-16  9:11         ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 03/12] ARM: OMAP2+: Add minimal clockdomains " Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 04/12] ARM: OMAP2+: Add custom prwdm_operations for 81xx to support dm814x Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 05/12] ARM: OMAP2+: Add support for initializing dm814x clocks Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-04 18:42   ` Stephen Boyd [this message]
2015-06-04 18:42     ` Stephen Boyd
2015-06-04 22:28     ` Tony Lindgren
2015-06-04 22:28       ` Tony Lindgren
2015-07-16  9:37       ` Tony Lindgren
2015-07-16  9:37         ` Tony Lindgren
2015-07-16 18:25         ` Stephen Boyd
2015-07-16 18:25           ` Stephen Boyd
2015-07-17  5:06           ` Tony Lindgren
2015-07-17  5:06             ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 06/12] ARM: OMAP2+: Prepare dm81xx hwmod code for adding minimal dm814x support Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 07/12] ARM: OMAP2: Add minimal dm814x hwmod support Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 08/12] ARM: dts: Add minimal dm814x support Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 09/12] ARM: dts: Add minimal clocks for dm814x Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 10/12] ARM: dts: Add minimal dts support for dm8148-evm Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 11/12] ARM: dts: Add minimal support for HP T410 Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren
2015-06-03 16:23 ` [PATCH 12/12] ARM: OMAP2+: Add custom abort handler for t410 Tony Lindgren
2015-06-03 16:23   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150604184254.GJ490@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=matthijsvanduin@gmail.com \
    --cc=mturquette@linaro.org \
    --cc=paul@pwsan.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.