From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Z0XrX-0005zG-CZ for mharc-grub-devel@gnu.org; Thu, 04 Jun 2015 12:19:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0XrU-0005z9-FV for grub-devel@gnu.org; Thu, 04 Jun 2015 12:19:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0XrQ-0004Et-F7 for grub-devel@gnu.org; Thu, 04 Jun 2015 12:19:20 -0400 Received: from mail-la0-x22f.google.com ([2a00:1450:4010:c03::22f]:33652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0XrQ-0004En-74 for grub-devel@gnu.org; Thu, 04 Jun 2015 12:19:16 -0400 Received: by labpy14 with SMTP id py14so35771434lab.0 for ; Thu, 04 Jun 2015 09:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=xh7N2WYphqn5FnfhlqbmLzeNz3ivQ5uU4YVBhO+wDrw=; b=apheU2zrM9B2bz0PcA1ynWCZ3DyNjS6gJxYP4ENFBkp8I+AVZW7Yu0ioK5p6lvL6It ra9GP1rEjo0Ov7yFwRFakwSLmztKJbcKRma5Q7qj4B8EK/pICZsr+IbRjRGaQ8rCqVXm HWKjSldoV5icbnACpBk+Mvbe0P68mpS9KTTIL822wfyFYKCv7uzWS+iMg6WZ+wDhMz9W bkr6jIxbhjoFqSCBowcjENGjtWKZ5rkYzYhHpX4W0KrdPQJxdAtC0WeGC2H0Tpjc0sqB h1SBky3TtKU+MXlduH8H9s8KdASRWy1/p9ZpdRZryq2PN2rWpKwh0sBNPWOmvJTBCu8Q b67g== X-Received: by 10.112.150.130 with SMTP id ui2mr38615719lbb.116.1433434755436; Thu, 04 Jun 2015 09:19:15 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id ox10sm870592lbc.30.2015.06.04.09.19.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 09:19:14 -0700 (PDT) Date: Thu, 4 Jun 2015 19:19:14 +0300 From: Andrei Borzenkov To: Toomas Soome Subject: Re: multiboot2.h & multiboot_header_tag_module_align Message-ID: <20150604191914.41653084@opensuse.site> In-Reply-To: References: <55706F68.5080100@gmail.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22f Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 16:19:21 -0000 =D0=92 Thu, 04 Jun 2015 19:04:46 +0300 Toomas Soome =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > > On 04.06.2015, at 18:31, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > >=20 > > On 04.06.2015 14:18, Toomas Soome wrote: > >> hi! > >>=20 > >> i know this tag (multiboot_header_tag_module_align) is not really used= , but it still would be nice if the copy/paste error of the actual structur= e would be fixed;) > >>=20 > > Can you propose a patch? > >> rgds, >=20 > as its header tag, i think following should be it; header tags have 16bit= ints for type and flags, 32bit size and based on name, this tag is to requ= est bootloader to use specified alignment, so the data field should be 32bi= t uint as well (default MULTIBOOT_MOD_ALIGN is 0x00001000). >=20 > diff --git a/include/multiboot2.h b/include/multiboot2.h > index 3ccff15..e3064da 100644 > --- a/include/multiboot2.h > +++ b/include/multiboot2.h > @@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align > multiboot_uint16_t type; > multiboot_uint16_t flags; > multiboot_uint32_t size; > - multiboot_uint32_t width; > - multiboot_uint32_t height; > - multiboot_uint32_t depth; > + multiboot_uint32_t align; What about consulting multiboot2 specification? :) > }; > =20 > struct multiboot_color >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel