From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752617AbbFDW3B (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Jun 2015 18:29:01 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:55503 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751931AbbFDW27 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Jun 2015 18:28:59 -0400
Date: Thu, 4 Jun 2015 23:28:57 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH 5/8] drivers/base/core.c: Use strreplace
Message-ID: <20150604222857.GM7232@ZenIV.linux.org.uk>
References: <1433410636-26812-1-git-send-email-linux@rasmusvillemoes.dk>
 <1433410636-26812-6-git-send-email-linux@rasmusvillemoes.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433410636-26812-6-git-send-email-linux@rasmusvillemoes.dk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 04, 2015 at 11:37:12AM +0200, Rasmus Villemoes wrote:
> This eliminates a local variable and a little .text.

Hmm...

>  	*tmp = kstrdup(dev_name(dev), GFP_KERNEL);
>  	if (!*tmp)
>  		return NULL;
> -	while ((s = strchr(*tmp, '!')))
> -		s[0] = '/';
> +	strreplace((char *)*tmp, '!', '/');
>  	return *tmp;

That cast isn't nice.  Why not make it
	s = kstrdup(...)
	if (s)
		strreplace(s, ...)
	return *tmp = s;
instead?