From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753933AbbFDWiF (ORCPT ); Thu, 4 Jun 2015 18:38:05 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:55527 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbbFDWiD (ORCPT ); Thu, 4 Jun 2015 18:38:03 -0400 Date: Thu, 4 Jun 2015 23:37:53 +0100 From: Al Viro To: Joe Perches Cc: Rasmus Villemoes , Andrew Morton , Daniel Borkmann , Herbert Xu , linux-kernel@vger.kernel.org Subject: Re: [RFC/PATCH 1/8] lib: string: Introduce strreplace Message-ID: <20150604223753.GO7232@ZenIV.linux.org.uk> References: <1433410636-26812-1-git-send-email-linux@rasmusvillemoes.dk> <1433410636-26812-2-git-send-email-linux@rasmusvillemoes.dk> <1433415367.4861.152.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433415367.4861.152.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 04, 2015 at 03:56:07AM -0700, Joe Perches wrote: > Seems sensible, but the name maybe could be be more > explicit as strreplace seems like it should more like > a string substitution rather than a char substitution. > > Maybe strsubstchr or something like it (strtranschr?) Why not go the full monty and call it strtrtsstrrrtst(), with strtrtssstrrtst() doing almost, but not quite the same thing?