From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0fre-00078d-Fy for qemu-devel@nongnu.org; Thu, 04 Jun 2015 20:52:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0frZ-0008St-Ls for qemu-devel@nongnu.org; Thu, 04 Jun 2015 20:52:02 -0400 Received: from mail-bn1bon0061.outbound.protection.outlook.com ([157.56.111.61]:61739 helo=na01-bn1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0frZ-0008Sj-Gr for qemu-devel@nongnu.org; Thu, 04 Jun 2015 20:51:57 -0400 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1Z0frU-0003EL-Lx for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:51:52 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1Z0frU-0002FO-Gp for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:51:52 -0700 Date: Fri, 5 Jun 2015 10:47:29 +1000 From: "Edgar E. Iglesias" Message-ID: <20150605004729.GV17878@toto> References: <4f6bd6c109a2f732cfe767cb54ede06ed7568845.1433314301.git.alistair.francis@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4f6bd6c109a2f732cfe767cb54ede06ed7568845.1433314301.git.alistair.francis@xilinx.com> Subject: Re: [Qemu-devel] [PATCH RESEND v1 7/8] s3adsp1800: Remove the hardcoded values from the reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org On Thu, Jun 04, 2015 at 11:25:11AM +1000, Alistair Francis wrote: > Remove the hardcoded values from the machine specific reset > function, as the same values are already set in the standard > MicroBlaze reset. > > This also allows the entire reset function to be deleted, as > PVR registers are now preserved on reset. > > Signed-off-by: Alistair Francis Reviewed-by: Edgar E. Iglesias > --- > hw/microblaze/petalogix_s3adsp1800_mmu.c | 9 +-------- > 1 files changed, 1 insertions(+), 8 deletions(-) > > diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c b/hw/microblaze/petalogix_s3adsp1800_mmu.c > index 84f6e74..7109e63 100644 > --- a/hw/microblaze/petalogix_s3adsp1800_mmu.c > +++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c > @@ -51,13 +51,6 @@ > #define ETHLITE_IRQ 1 > #define UARTLITE_IRQ 3 > > -static void machine_cpu_reset(MicroBlazeCPU *cpu) > -{ > - CPUMBState *env = &cpu->env; > - > - env->pvr.regs[10] = 0x0c000000; /* spartan 3a dsp family. */ > -} > - > static void > petalogix_s3adsp1800_init(MachineState *machine) > { > @@ -132,7 +125,7 @@ petalogix_s3adsp1800_init(MachineState *machine) > microblaze_load_kernel(cpu, ddr_base, ram_size, > machine->initrd_filename, > BINARY_DEVICE_TREE_FILE, > - machine_cpu_reset); > + NULL); > } > > static QEMUMachine petalogix_s3adsp1800_machine = { > -- > 1.7.1 >