From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1Z0fsY-0008IC-Gn
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 20:52:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1Z0fsV-0000CK-BP
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 20:52:58 -0400
Received: from mail-bn1on0097.outbound.protection.outlook.com
	([157.56.110.97]:15232
	helo=na01-bn1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1Z0fsV-0000CG-6T
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 20:52:55 -0400
Received: from unknown-38-66.xilinx.com ([149.199.38.66]:41215
	helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1Z0fsS-0000SC-Tq
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:52:52 -0700
Received: from [127.0.0.1] (helo=localhost)
	by xsj-pvapsmtp01 with smtp (Exim 4.63)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1Z0fsS-0002Ns-OY
	for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:52:52 -0700
Date: Fri, 5 Jun 2015 10:48:30 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Message-ID: <20150605004830.GW17878@toto>
References: <cover.1433314301.git.alistair.francis@xilinx.com>
	<e1cf24a77d0d3ad134ad55dcb8be0b391b57b30e.1433314301.git.alistair.francis@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e1cf24a77d0d3ad134ad55dcb8be0b391b57b30e.1433314301.git.alistair.francis@xilinx.com>
Subject: Re: [Qemu-devel] [PATCH RESEND v1 8/8] target-microblaze: Remove
	dead code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org

On Thu, Jun 04, 2015 at 11:25:49AM +1000, Alistair Francis wrote:
> This code is already being run in the mb_cpu_realizefn()
> function. As PVR registers are preserved on reset this
> code is not required.

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>  target-microblaze/cpu.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index 329d4d5..437250d 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -129,10 +129,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **errp)
>  
>      env->sregs[SR_PC] = cpu->cfg.base_vectors;
>  
> -#if defined(CONFIG_USER_ONLY)
> -    env->pvr.regs[10] = 0x0c000000; /* Spartan 3a dsp.  */
> -#endif
> -
>      mcc->parent_realize(dev, errp);
>  }
>  
> -- 
> 1.7.1
>