From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: bridge/dw_hdmi: Return num_modes in dw_hdmi_connector_get_modes Date: Fri, 5 Jun 2015 12:02:40 +0200 Message-ID: <20150605100237.GC6436@ulmo.nvidia.com> References: <1433441076-20049-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by gabe.freedesktop.org (Postfix) with ESMTP id E14E96EC0C for ; Fri, 5 Jun 2015 03:03:07 -0700 (PDT) In-Reply-To: <1433441076-20049-1-git-send-email-dianders@chromium.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson Cc: fabio.estevam@freescale.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, Russell King , andy.yan@rock-chips.com List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMDQsIDIwMTUgYXQgMTE6MDQ6MzZBTSAtMDcwMCwgRG91ZyBBbmRlcnNvbiB3 cm90ZToKPiBUaGUgZHdfaGRtaV9jb25uZWN0b3JfZ2V0X21vZGVzKCkgZnVuY3Rpb24gYWNjaWRl bnRhbGx5IGZvcmdldHMgdG8KPiByZXR1cm4gdGhlIG51bWJlciBvZiBtb2RlcyBpdCBhZGRlZCwg YWx0aG91Z2ggaXQgaGFzIHRoaXMgaW5mb3JtYXRpb24KPiBzdG9yZWQgaW4gYSBsb2NhbCB2YXJp YWJsZS4gIExldCdzIGZpeCB0aGF0Lgo+IAo+IFdpdGhvdXQgdGhpcyBmaXgsIGRybV9oZWxwZXJf cHJvYmVfc2luZ2xlX2Nvbm5lY3Rvcl9tb2Rlc19tZXJnZV9iaXRzKCkKPiBjb3VsZCBnZXQgY29u ZnVzZWQgYW5kIGFsd2F5cyBjYWxsIGRybV9hZGRfbW9kZXNfbm9lZGlkKCkuICBUaGF0J3Mgbm90 Cj4gcmlnaHQuCj4gCj4gU2lnbmVkLW9mZi1ieTogRG91ZyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hy b21pdW0ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3X2hkbWkuYyB8IDQg KystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoK QXBwbGllZCwgdGhhbmtzLgoKVGhpZXJyeQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397AbbFEKDK (ORCPT ); Fri, 5 Jun 2015 06:03:10 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:1882 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbbFEKDH (ORCPT ); Fri, 5 Jun 2015 06:03:07 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 05 Jun 2015 02:59:14 -0700 Date: Fri, 5 Jun 2015 12:02:40 +0200 From: Thierry Reding To: Doug Anderson CC: Philipp Zabel , Russell King , , , , , , Subject: Re: [PATCH] drm: bridge/dw_hdmi: Return num_modes in dw_hdmi_connector_get_modes Message-ID: <20150605100237.GC6436@ulmo.nvidia.com> References: <1433441076-20049-1-git-send-email-dianders@chromium.org> MIME-Version: 1.0 In-Reply-To: <1433441076-20049-1-git-send-email-dianders@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [10.2.71.62] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 04, 2015 at 11:04:36AM -0700, Doug Anderson wrote: > The dw_hdmi_connector_get_modes() function accidentally forgets to > return the number of modes it added, although it has this information > stored in a local variable. Let's fix that. > > Without this fix, drm_helper_probe_single_connector_modes_merge_bits() > could get confused and always call drm_add_modes_noedid(). That's not > right. > > Signed-off-by: Doug Anderson > --- > drivers/gpu/drm/bridge/dw_hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Thierry