All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: mingo@redhat.com, ak@linux.intel.com,
	Michael Ellerman <mpe@ellerman.id.au>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V14 00/14] perf, tools: Add support for PMU events in JSON format
Date: Fri, 5 Jun 2015 12:29:07 +0200	[thread overview]
Message-ID: <20150605102907.GA17556@krava.redhat.com> (raw)
In-Reply-To: <1433485647-9314-1-git-send-email-sukadev@linux.vnet.ibm.com>

On Thu, Jun 04, 2015 at 11:27:08PM -0700, Sukadev Bhattiprolu wrote:

SNIP

> 	- All known events tables for the architecture are included in the
> 	  perf binary.
> 
> 	- For architectures that don't have any JSON files, an empty mapping
> 	  table is created and they should continue to build)
> 
> Thanks to input from Andi Kleen, Jiri Olsa, Namhyung Kim and Ingo Molnar.
> 
> These patches are available from:
> 
> 	https://github.com:sukadev/linux.git 
> 	
> 		Branch			Description
> 		------------------------------------------------------
> 		json-v14		Source Code only 
> 		json-files-3		x86 and Powerpc datafiles only
> 		json-v14-with-data	Both code and data (build/test)
> 	
> NOTE: 	Only "source code" patches (i.e those in json-v14) are being emailed.
> 	Please pull the "data files" from the json-files-3 branch.
> 
> Changelog[v14]
> 	Comments from Jiri Olsa:
> 	- Change parameter name/type for pmu_add_cpu_aliases (from void *data
> 	  to list_head *head)
> 	- Use asprintf() in file_name_to_tablename() and simplify/reorg code.
> 	- Use __weak definition from <linux/compile.h>
> 	- Use fopen() with mode "w" and eliminate unlink()
> 	- Remove minor TODO.
> 	- Add error check for return value from strdup() in print_pmu_events().
> 	- Move independent changes from patches 3,11,12 .. to separate patches
> 	  for easier review/backport.
> 	- Clarify mapfile's "header line support" in patch description.
> 	- Fix build failure with DEBUG=1

all my comments were addressed and apart from 2 small comments,
for the patchset:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

      parent reply	other threads:[~2015-06-05 10:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  6:27 [PATCH V14 00/14] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 01/19] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 02/19] perf, tools, jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 03/19] Use __weak definition from <linux/compiler.h> Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 04/19] perf, tools: Split perf_pmu__new_alias() Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 05/19] perf, tools: Use pmu_events table to create aliases Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 06/19] perf, tools: Support CPU ID matching for Powerpc Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 07/19] perf, tools: Allow events with dot Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 08/19] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 09/19] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-06-05 10:21   ` Jiri Olsa
2015-06-05  6:27 ` [PATCH v14 10/19] perf, tools: Query terminal width and use in perf list Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 11/19] perf, tools: Add a --no-desc flag to " Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 12/19] perf, tools: Add override support for event list CPUID Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 13/19] perf, tools, jevents: Add support for long descriptions Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 14/19] perf, tools: Add alias " Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 15/19] perf, tools: Support long descriptions with perf list Sukadev Bhattiprolu
2015-06-05 10:21   ` Jiri Olsa
2015-06-05 16:19     ` Andi Kleen
2015-06-05 18:16       ` Sukadev Bhattiprolu
2015-06-06  7:08         ` Jiri Olsa
2015-06-05  6:27 ` [PATCH v14 16/19] perf, tools, jevents: Add support for event topics Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 17/19] perf, tools: Add support for event list topics Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 18/19] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 19/19] perf, tools: Add README for info on parsing JSON/map files Sukadev Bhattiprolu
2015-06-05 10:29 ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150605102907.GA17556@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.