From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/nouveau/disp: Use NULL for pointers Date: Fri, 5 Jun 2015 13:33:43 +0200 Message-ID: <20150605113342.GE17776@ulmo.nvidia.com> References: <1405944178-3500-1-git-send-email-thierry.reding@gmail.com> <20141013114749.GA16186@ulmo> <543C2529.2080708@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0295944928==" Return-path: Received: from mail-qc0-f169.google.com (mail-qc0-f169.google.com [209.85.216.169]) by gabe.freedesktop.org (Postfix) with ESMTP id BA3FE6E2A1 for ; Fri, 5 Jun 2015 04:34:07 -0700 (PDT) Received: by qcxw10 with SMTP id w10so28686210qcx.3 for ; Fri, 05 Jun 2015 04:34:06 -0700 (PDT) In-Reply-To: <543C2529.2080708@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Ben Skeggs , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0295944928== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wTWi5aaYRw9ix9vO" Content-Disposition: inline --wTWi5aaYRw9ix9vO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 13, 2014 at 08:16:57PM +0100, Emil Velikov wrote: > On 13/10/14 12:47, Thierry Reding wrote: > > On Mon, Jul 21, 2014 at 02:02:58PM +0200, Thierry Reding wrote: > >> From: Thierry Reding > >> > >> The return type of exec_lookup() is struct nvkm_output *, so it should > >> return NULL rather than 0. > >> > >> Signed-off-by: Thierry Reding > >> --- > >> drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c b/drivers= /gpu/drm/nouveau/core/engine/disp/nvd0.c > >> index fa30d8196f35..ebf64e1d0a70 100644 > >> --- a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c > >> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c > >> @@ -939,7 +939,7 @@ exec_lookup(struct nv50_disp_priv *priv, int head,= int or, u32 ctrl, > >> case 0x00000900: type =3D DCB_OUTPUT_DP; mask =3D 2; break; > >> default: > >> nv_error(priv, "unknown SOR mc 0x%08x\n", ctrl); > >> - return 0x0000; > >> + return NULL; > >> } > >> } > >> =20 > >=20 > > Ping? > >=20 > > Thierry > >=20 > I have an identical patch in a local branch, but with worse commit > message :) Fwiw the patch is >=20 > Reviewed-by: Emil Velikov Ben, any chance you could pick this up? It should still apply as-is on recent trees, but I can resend if you prefer. Thierry --wTWi5aaYRw9ix9vO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVcYkWAAoJEN0jrNd/PrOhtP8P/icRMfwJOtg7GjkW31sNj32I ksMoAx5WvfhrhqHAdn4589SMCuIdv/aZtqr2WsYPxOYVC0MbKEHI1RM6VOTHP3gO C76gupKLQF1+BGq92/0bzaHMaQN46U54ZX4JAC8MW8YX23BipjrIcfYKfGDy9Mmc 8Q8qe0l069hYr8axlMDTGrrYFJFf93CAqqYdqHTiTpVXX/C/fQvTBkrSsmzs42Df TADle5ZwhLePf6KI2TszFGIpSpgANat/oGd2TXGAXv02wc9xXLvR3hDIRWwI+N1A b+o+fK/VWLYY/PqS+LwhMGFolucK5DYstd+1Pd1i/yUbft8caSD1tZCyTUId2d/n X1ZGpUTp/yVaA+QyHGW82x1gMdvm25fg8l9YoXndbqkOpaa6JXbtI8KRnrRX4oHj NCqTKBFRwn/o8Sp+Jq4BJCkBdqdLbtRNSyhTayr0ARUMu8LeSjAQjwQQW/ueFd/L FAfkObfzg++Z90jxP1EoJQGsdFO+Az9UA/OONKC6mvfvxfwjXRVrjgXFPBXLd7j7 4aCs4p7jsbvZSUD0cREfKc9j9TTOXBYExifuF/YOn0SYS935LHosxF4aB6C+/Mp6 ltkjdPKJmQf8NhebBQOiI7LXmHd7oJTfOvUXC6UnW6op5DgWbPtsON3bWlPfX+fe 9FjWyb9+mlyS2fNRk/Xi =1kVZ -----END PGP SIGNATURE----- --wTWi5aaYRw9ix9vO-- --===============0295944928== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0295944928==--