From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: Add display timing for Okaya RS800480T-7X0GP Date: Fri, 5 Jun 2015 14:28:10 +0200 Message-ID: <20150605122809.GB759@ulmo.nvidia.com> References: <1432827466-8104-1-git-send-email-gary.bisson@boundarydevices.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0578124671==" Return-path: Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) by gabe.freedesktop.org (Postfix) with ESMTP id E33A16EC16 for ; Fri, 5 Jun 2015 05:28:33 -0700 (PDT) Received: by qcxw10 with SMTP id w10so29171188qcx.3 for ; Fri, 05 Jun 2015 05:28:33 -0700 (PDT) In-Reply-To: <1432827466-8104-1-git-send-email-gary.bisson@boundarydevices.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gary Bisson Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0578124671== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kXdP64Ggrk/fb43R" Content-Disposition: inline --kXdP64Ggrk/fb43R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 28, 2015 at 05:37:46PM +0200, Gary Bisson wrote: > Add support for the Okaya RS800480T-7X0GP to the DRM simple panel > driver. >=20 > The RS800480T-7X0GP is a WVGA (800x480) panel with an 18-bit parallel > LCD interface. It supports pixel clocks in the range of 30-40 MHz. >=20 > This panel details can be found at: > http://boundarydevices.com/product/7-800x480-display/ >=20 > Signed-off-by: Gary Bisson > --- > Hi all, >=20 > This patch is the follow-up of a request from Philipp to add the Okaya di= splay > to the simple panel driver. > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/346657.html >=20 > Regards, > Gary > --- > .../bindings/panel/okaya,rs800480t_7x0gp.txt | 7 ++++++ > .../devicetree/bindings/vendor-prefixes.txt | 1 + > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++= ++++++ > 3 files changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/panel/okaya,rs80048= 0t_7x0gp.txt >=20 > diff --git a/Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0g= p.txt b/Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0gp.txt > new file mode 100644 > index 0000000..f7c729d > --- /dev/null > +++ b/Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0gp.txt > @@ -0,0 +1,7 @@ > +OKAYA Electric America, Inc. RS800480T-7X0GP 7" WVGA LCD panel > + > +Required properties: > +- compatible: should be "okaya,rs800480t_7x0gp" > + > +This binding is compatible with the simple-panel binding, which is speci= fied > +in simple-panel.txt in this directory. > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Docu= mentation/devicetree/bindings/vendor-prefixes.txt > index 4f35a00..06ce91c 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -145,6 +145,7 @@ nintendo Nintendo > nokia Nokia > nvidia NVIDIA > nxp NXP Semiconductors > +okaya OKAYA Electric America, Inc. > onnn ON Semiconductor Corp. > opencores OpenCores.org > ortustech Ortus Technology Co., Ltd. Can you split this change into a separate patch? It needs an Acked-by =66rom one of the device tree binding maintainers, so make sure to Cc them when you repost. scripts/get_maintainer.pl will list them for you. > +static const struct display_timing okaya_rs800480t_7x0gp_timing =3D { > + .pixelclock =3D { 30000000, 30000000, 40000000 }, > + .hactive =3D { 800, 800, 800 }, > + .hfront_porch =3D { 40, 40, 40 }, > + .hback_porch =3D { 40, 40, 40 }, > + .hsync_len =3D { 1, 48, 48 }, > + .vactive =3D { 480, 480, 480 }, > + .vfront_porch =3D { 13, 13, 13 }, > + .vback_porch =3D { 29, 29, 29 }, > + .vsync_len =3D { 3, 3, 3 }, It strikes me as odd that the porches and VSYNC width should be fixed for the panel. Is this really the case? Thierry --kXdP64Ggrk/fb43R Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVcZXZAAoJEN0jrNd/PrOhdtkP/Rtj5Hq4hr9ziKIVSAB3vvtC 6ERzc7EXGYW4JmMAuc6UsiR6oQcGOatC51msTN6IrJ7p+6cQDXk31Pwe2lJwCsws Z12c7qlE8Gnu6yEg0Mm7iQ94iPDdyuaxgXsQS4nnq/uf0XBhNC4CLZGedIJkkYiB JWfPDc9X2Meo6hRhT2voUMvF4ML5B5gadMtJ/tmba6WwkDjG+/WtTIEc84Ni5zSx 10LLitFrTzloNXaXqd4U49QDdqTSvwdGKo3GJYAz8v8m8Kh/1u3shB+G8hR59bEV J4sJit/GM849SEKadRJVCYlDHyPaCifclPgqvAwpwIEOE36hU9ZyOnnG42bLpCuD JZHw3qJdqT+GTVuYvgbuznOpBFqAz5Ig+I+M6kaqn1RaklF/U3i/M31BzDwdXPz4 gwn2dicBW7X8NKfk1u18Odti4onpHliTf/orAXC1q6rKiotUPearH9fRUUh+qaHi X4j+jlXhY2rCkEKAPCQ7Puyohxd5lttBr3Lw/QjqXgjF5Tv8ILe6v4UThIpxSVaL NLdVyp1bP/HMNaPAVVgM3xw2OjBGoEcKulNBtXYe2GQLR7DxgAn1XcL8gL1a/6DX 9/nHps6Pj9L68APPP12ANrMst8dAghloZ94eFEE6H31z5lM3tLh6S62W6iOY9lru wLu7fbE07CD6NGgaBnHg =auF1 -----END PGP SIGNATURE----- --kXdP64Ggrk/fb43R-- --===============0578124671== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0578124671==--