diff for duplicates of <20150605141830.GM3387@localhost.localdomain> diff --git a/a/1.txt b/N1/1.txt index 708264c..051d8a4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -64,7 +64,7 @@ On Thu, Jun 04, 2015 at 10:27:10AM -0400, Neil Horman wrote: > > + > > + spin_lock_bh(&net->sctp.addr_wq_lock); > > + list_for_each_entry_rcu(temp, &net->sctp.addr_waitq, list) { -> > + if (temp = addrw) { +> > + if (temp == addrw) { > > + list_del_rcu(&addrw->list); > > + kfree_rcu(addrw, rcu); > > + } @@ -141,7 +141,7 @@ No, we don't. I'll remove these. > > + list_for_each_entry_rcu(addrw, &net->sctp.addr_waitq, list) { > > if (addrw->a.sa.sa_family != addr->a.sa.sa_family) > > continue; -> > if (addrw->a.sa.sa_family = AF_INET) { +> > if (addrw->a.sa.sa_family == AF_INET) { > > @@ -702,7 +720,7 @@ void sctp_addr_wq_mgmt(struct net *net, struct sctp_sockaddr_entry *addr, int cm > > * new address after a couple of addition and deletion of that address > > */ @@ -168,7 +168,7 @@ No, we don't. I'll remove these. > > > > /* OK, we have to add the new address to the wait queue */ > > addrw = kmemdup(addr, sizeof(struct sctp_sockaddr_entry), GFP_ATOMIC); -> > - if (addrw = NULL) { +> > - if (addrw == NULL) { > > - spin_unlock_bh(&net->sctp.addr_wq_lock); > > + if (!addrw) > > return; diff --git a/a/content_digest b/N1/content_digest index 21a0c5d..7b6385d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020150604142710.GD24585@hmsreliant.think-freely.org\0" "From\0Marcelo Ricardo Leitner <mleitner@redhat.com>\0" "Subject\0Re: [PATCH v2 1/2] sctp: rcu-ify addr_waitq\0" - "Date\0Fri, 05 Jun 2015 14:18:30 +0000\0" + "Date\0Fri, 5 Jun 2015 11:18:30 -0300\0" "To\0Neil Horman <nhorman@tuxdriver.com>\0" "Cc\0netdev@vger.kernel.org" linux-sctp@vger.kernel.org @@ -78,7 +78,7 @@ "> > +\n" "> > +\tspin_lock_bh(&net->sctp.addr_wq_lock);\n" "> > +\tlist_for_each_entry_rcu(temp, &net->sctp.addr_waitq, list) {\n" - "> > +\t\tif (temp = addrw) {\n" + "> > +\t\tif (temp == addrw) {\n" "> > +\t\t\tlist_del_rcu(&addrw->list);\n" "> > +\t\t\tkfree_rcu(addrw, rcu);\n" "> > +\t\t}\n" @@ -155,7 +155,7 @@ "> > +\tlist_for_each_entry_rcu(addrw, &net->sctp.addr_waitq, list) {\n" "> > \t\tif (addrw->a.sa.sa_family != addr->a.sa.sa_family)\n" "> > \t\t\tcontinue;\n" - "> > \t\tif (addrw->a.sa.sa_family = AF_INET) {\n" + "> > \t\tif (addrw->a.sa.sa_family == AF_INET) {\n" "> > @@ -702,7 +720,7 @@ void sctp_addr_wq_mgmt(struct net *net, struct sctp_sockaddr_entry *addr, int cm\n" "> > \t * new address after a couple of addition and deletion of that address\n" "> > \t */\n" @@ -182,7 +182,7 @@ "> > \n" "> > \t/* OK, we have to add the new address to the wait queue */\n" "> > \taddrw = kmemdup(addr, sizeof(struct sctp_sockaddr_entry), GFP_ATOMIC);\n" - "> > -\tif (addrw = NULL) {\n" + "> > -\tif (addrw == NULL) {\n" "> > -\t\tspin_unlock_bh(&net->sctp.addr_wq_lock);\n" "> > +\tif (!addrw)\n" "> > \t\treturn;\n" @@ -205,4 +205,4 @@ "\n" Marcelo -bdd1598b96d1c9ebe121e3d9806c75553da213876c18c577c1e6ac21f3ab4a5f +42e02c802c8b049dac77930c46c8410491687b705544ca6f4e2a303b127e7e21
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.