From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/6] intel: Defer setting madv on the bo cache Date: Fri, 5 Jun 2015 09:34:23 -0700 Message-ID: <20150605163421.GA17650@intel.com> References: <1430816040-25285-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id C61476E259 for ; Fri, 5 Jun 2015 09:34:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1430816040-25285-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org U29ycnkuIEkga25vdyBJIGFza2VkIHNvbWUgcXVlc3Rpb25zIGxhc3QgdGltZSBhcm91bmQsIGJ1 dCBJIGFtIGhhdmluZyB0cm91YmxlCmZpbmRpbmcgdGhlIHJlc3BvbnNlLgoKT24gVHVlLCBNYXkg MDUsIDIwMTUgYXQgMDk6NTM6NTVBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IENvbnZl cnQgdGhlIGJvLWNhY2hlIGludG8gMiBwaGFzZXM6Cj4gCj4gMS4gQSB0d28gc2Vjb25kIGNhY2hl IG9mIHJlY2VudGx5IHVzZWQgYnVmZmVycywga2VlcCB1bnRvdWNoZWQuCj4gMi4gQSB0d28gc2Vj b25kIGNhY2hlIG9mIG9sZGVyIGJ1ZmZlcnMsIG1hcmtlZCBmb3IgZXZpY3Rpb24uCj4gCj4gVGhp cyBoZWxwcyByZWR1Y2UgaW9jdGwgdHJhZmZpYyBvbiBhIHJhcGlkIHR1cm5vdmVyIGluIHdvcmtp bmcgc2V0cy4gVGhlCj4gaXNzdWUgaXMgdGhhdCBldmVuIGEgMiBzZWNvbmQgd2luZG93IGlzIGVu b3VnaCBmb3IgYW4gYXBwbGljYXRpb24gdG8KPiBmaWxsIGFsbCBvZiBtZW1vcnkgd2l0aCBpbmFj dGl2ZSBidWZmZXJzIChhbmQgd2Ugd291bGQgcmVseSBvbiB0aGUKPiBvb20ta2lsbGVyIGlkZW50 aWZ5aW5nIHRoZSByaWdodCBjdWxwcml0KS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiBDYzogQmVuIFdpZGF3c2t5IDxiZW5qYW1pbi53aWRhd3NreUBp bnRlbC5jb20+Cj4gLS0tCj4gIGludGVsL2ludGVsX2J1Zm1ncl9nZW0uYyB8IDI3ICsrKysrKysr KysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwg NyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaW50ZWwvaW50ZWxfYnVmbWdyX2dlbS5j IGIvaW50ZWwvaW50ZWxfYnVmbWdyX2dlbS5jCj4gaW5kZXggNjBjMDZmYy4uZWViOWFjZiAxMDA2 NDQKPiAtLS0gYS9pbnRlbC9pbnRlbF9idWZtZ3JfZ2VtLmMKPiArKysgYi9pbnRlbC9pbnRlbF9i dWZtZ3JfZ2VtLmMKPiBAQCAtMjE2LDYgKzIxNiwxMSBAQCBzdHJ1Y3QgX2RybV9pbnRlbF9ib19n ZW0gewo+ICAJYm9vbCB1c2VkX2FzX3JlbG9jX3RhcmdldDsKPiAgCj4gIAkvKioKPiArCSAqIEFy ZSB3ZSBrZWVwaW5nIHRoaXMgYnVmZmVyIGFyb3VuZCBpbiBzZW1pLXBlcm1lbmFudCBjYWNoZT8K PiArCSAqLwo+ICsJYm9vbCBkb250bmVlZDsKPiArCj4gKwkvKioKPiAgCSAqIEJvb2xlYW4gb2Yg d2hldGhlciB3ZSBoYXZlIGVuY291bnRlcmVkIGFuIGVycm9yIHdoaWxzdCBidWlsZGluZyB0aGUg cmVsb2NhdGlvbiB0cmVlLgo+ICAJICovCj4gIAlib29sIGhhc19lcnJvcjsKPiBAQCAtNzE5LDcg KzcyNCw4IEBAIHJldHJ5Ogo+ICAJCX0KPiAgCj4gIAkJaWYgKGFsbG9jX2Zyb21fY2FjaGUpIHsK PiAtCQkJaWYgKCFkcm1faW50ZWxfZ2VtX2JvX21hZHZpc2VfaW50ZXJuYWwKPiArCQkJaWYgKGJv X2dlbS0+ZG9udG5lZWQgJiYKPiArCQkJICAgICFkcm1faW50ZWxfZ2VtX2JvX21hZHZpc2VfaW50 ZXJuYWwKCldoeSB3b3VsZG4ndCB5b3Ugc2V0IGRvbnRuZWVkID0gZmFsc2U/IEp1c3QgYSB0aG91 Z2h0LCBidXQgaXQgc2VlbXMgbGlrZSBhIG5pY2VyCnNvbHV0aW9uIGhlcmUgd291bGQganVzdCBi ZSBhIHN0YXRlIHZhcmlhYmxlIHRyYWNraW5nIHdoYXQgd2UgbGFzdCBzZW50IHdpdGggdGhlCm1h ZHYgaW9jdGwuCgplbnVtIHsKICBXSUxMTkVFRAogIERPTlRORUVECn0KCldpdGggdGhhdCwgaXQg bWlnaHQgYmUgY29vbCBmb3IgdGhlIGN1cmlvdXMgdG8gcHV0IGEgaGlzdG9ncmFtL2h5c3RlcmVz aXMgdGhpbmcuCkV2ZXJ5IHRpbWUgeW91IGhpdCB0aGlzIGNvbmRpdGlvbiB0byBzZWUgaG93IG1h bnkgdGltZXMgd2UgZmxpcCBmbG9wLgoKPiAgCQkJICAgIChidWZtZ3JfZ2VtLCBib19nZW0sIEk5 MTVfTUFEVl9XSUxMTkVFRCkpIHsKPiAgCQkJCWRybV9pbnRlbF9nZW1fYm9fZnJlZSgmYm9fZ2Vt LT5ibyk7Cj4gIAkJCQlkcm1faW50ZWxfZ2VtX2JvX2NhY2hlX3B1cmdlX2J1Y2tldChidWZtZ3Jf Z2VtLAo+IEBAIC0xMTY2LDE5ICsxMTcyLDI4IEBAIGRybV9pbnRlbF9nZW1fY2xlYW51cF9ib19j YWNoZShkcm1faW50ZWxfYnVmbWdyX2dlbSAqYnVmbWdyX2dlbSwgdGltZV90IHRpbWUpCj4gIAlm b3IgKGkgPSAwOyBpIDwgYnVmbWdyX2dlbS0+bnVtX2J1Y2tldHM7IGkrKykgewo+ICAJCXN0cnVj dCBkcm1faW50ZWxfZ2VtX2JvX2J1Y2tldCAqYnVja2V0ID0KPiAgCQkgICAgJmJ1Zm1ncl9nZW0t PmNhY2hlX2J1Y2tldFtpXTsKPiArCQlkcm1NTUxpc3RIZWFkIG1hZHY7Cj4gIAo+ICsJCURSTUlO SVRMSVNUSEVBRCgmbWFkdik7Cj4gIAkJd2hpbGUgKCFEUk1MSVNURU1QVFkoJmJ1Y2tldC0+aGVh ZCkpIHsKPiAgCQkJZHJtX2ludGVsX2JvX2dlbSAqYm9fZ2VtOwo+ICAKPiAgCQkJYm9fZ2VtID0g RFJNTElTVEVOVFJZKGRybV9pbnRlbF9ib19nZW0sCj4gIAkJCQkJICAgICAgYnVja2V0LT5oZWFk Lm5leHQsIGhlYWQpOwo+IC0JCQlpZiAodGltZSAtIGJvX2dlbS0+ZnJlZV90aW1lIDw9IDEpCj4g KwkJCWlmICh0aW1lIC0gYm9fZ2VtLT5mcmVlX3RpbWUgPCAyKigxK2JvX2dlbS0+ZG9udG5lZWQp KQo+ICAJCQkJYnJlYWs7Cj4gIAo+ICAJCQlEUk1MSVNUREVMKCZib19nZW0tPmhlYWQpOwo+IC0K PiAtCQkJZHJtX2ludGVsX2dlbV9ib19mcmVlKCZib19nZW0tPmJvKTsKPiArCQkJaWYgKGJvX2dl bS0+ZG9udG5lZWQpIHsKPiArCQkJCWRybV9pbnRlbF9nZW1fYm9fZnJlZSgmYm9fZ2VtLT5ibyk7 Cj4gKwkJCX0gZWxzZSB7Cj4gKwkJCQlkcm1faW50ZWxfZ2VtX2JvX21hZHZpc2VfaW50ZXJuYWwo YnVmbWdyX2dlbSwgYm9fZ2VtLAo+ICsJCQkJCQkJCSAgSTkxNV9NQURWX0RPTlRORUVEKTsKPiAr CQkJCWJvX2dlbS0+ZG9udG5lZWQgPSAxOwo+ICsJCQkJRFJNTElTVEFERFRBSUwoJmJvX2dlbS0+ aGVhZCwgJm1hZHYpOwo+ICsJCQl9Cj4gIAkJfQoKQWdhaW4gd2l0aCBhYm92ZSwgaG93IGFib3V0 Pwphc3NlcnQoIWJvX2dlbS0+ZG9udG5lZWQpOwpib19nZW0tPmRvbnRuZWVkID0gdHJ1ZTsKCkFs c28gSSB0aGluayBzb21lIGNvbW1lbnRzIGhlcmUgZXhwbGFpbmluZyB3aGF0IHlvdSdyZSBkb2lu ZyBvdmVyYWxsIHdvdWxkIGJjZQpuaWNlIHNpbmNlIEkgc3VyZWx5IHdvbid0IHJlbWVtYmVyIGl0 IGluID49IDEgbWludXRlcy4KCj4gKwkJRFJNTElTVEpPSU4oJm1hZHYsICZidWNrZXQtPmhlYWQp Owo+ICAJfQo+ICAKPiAgCWJ1Zm1ncl9nZW0tPnRpbWUgPSB0aW1lOwo+IEBAIC0xMjg5LDkgKzEz MDQsNyBAQCBkcm1faW50ZWxfZ2VtX2JvX3VucmVmZXJlbmNlX2ZpbmFsKGRybV9pbnRlbF9ibyAq Ym8sIHRpbWVfdCB0aW1lKQo+ICAKPiAgCWJ1Y2tldCA9IGRybV9pbnRlbF9nZW1fYm9fYnVja2V0 X2Zvcl9zaXplKGJ1Zm1ncl9nZW0sIGJvLT5zaXplKTsKPiAgCS8qIFB1dCB0aGUgYnVmZmVyIGlu dG8gb3VyIGludGVybmFsIGNhY2hlIGZvciByZXVzZSBpZiB3ZSBjYW4uICovCj4gLQlpZiAoYnVm bWdyX2dlbS0+Ym9fcmV1c2UgJiYgYm9fZ2VtLT5yZXVzYWJsZSAmJiBidWNrZXQgIT0gTlVMTCAm Jgo+IC0JICAgIGRybV9pbnRlbF9nZW1fYm9fbWFkdmlzZV9pbnRlcm5hbChidWZtZ3JfZ2VtLCBi b19nZW0sCj4gLQkJCQkJICAgICAgSTkxNV9NQURWX0RPTlRORUVEKSkgewo+ICsJaWYgKGJ1Zm1n cl9nZW0tPmJvX3JldXNlICYmIGJvX2dlbS0+cmV1c2FibGUgJiYgYnVja2V0ICE9IE5VTEwpIHsK PiAgCQlib19nZW0tPmZyZWVfdGltZSA9IHRpbWU7Cj4gIAo+ICAJCWJvX2dlbS0+bmFtZSA9IE5V TEw7CgpKdXN0IHRvIGJlIGNsZWFyLCB5b3UncmUgcmVkdWNpbmcgSU9DVEwgdHJhZmZpYyBieSBk ZWZlcnJpbmcgYW4gSU9DVEwgdW50aWwgeW91CmNsZWFudXAgdGhlIEJPIGNhY2hlLgoKSSB0aGlu ayBJIHNhaWQgaXQgbGFzdCB0aW1lLCBvdmVyYWxsIHRoZSBpZGVhIHNlZW1zIGZpbmUgdG8gbWUu CgoKLS0gCkJlbiBXaWRhd3NreSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK