From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 05/12] fs/iso9660: rename all variables to use the ROOTFS_ISO9660 prefix
Date: Fri, 5 Jun 2015 23:20:31 +0200 [thread overview]
Message-ID: <20150605212031.GE3641@free.fr> (raw)
In-Reply-To: <1433430330-2166-6-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2015-06-04 17:05 +0200, Thomas Petazzoni spake thusly:
> For consistency reasons, this commit renames all internal variables of
> iso9660.mk to use the ROOTFS_ISO9660 prefix.
>
> While we're at it, replace a useless ':=' by '='.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> fs/iso9660/iso9660.mk | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/fs/iso9660/iso9660.mk b/fs/iso9660/iso9660.mk
> index 6a04fe6..0c7ef3b 100644
> --- a/fs/iso9660/iso9660.mk
> +++ b/fs/iso9660/iso9660.mk
> @@ -4,39 +4,39 @@
> #
> ################################################################################
>
> -ISO9660_TARGET_DIR = $(BUILD_DIR)/iso9660
> -ISO9660_BOOT_MENU := $(call qstrip,$(BR2_TARGET_ROOTFS_ISO9660_BOOT_MENU))
> +ROOTFS_ISO9660_TARGET_DIR = $(BUILD_DIR)/iso9660
> +ROOTFS_ISO9660_BOOT_MENU = $(call qstrip,$(BR2_TARGET_ROOTFS_ISO9660_BOOT_MENU))
>
> ROOTFS_ISO9660_DEPENDENCIES = grub host-cdrkit host-fakeroot linux rootfs-cpio
>
> ifeq ($(BR2_TARGET_GRUB_SPLASH),)
> define ROOTFS_ISO9660_SPLASHSCREEN
> - $(SED) '/^splashimage/d' $(ISO9660_TARGET_DIR)/boot/grub/menu.lst
> + $(SED) '/^splashimage/d' $(ROOTFS_ISO9660_TARGET_DIR)/boot/grub/menu.lst
> endef
> else
> define ROOTFS_ISO9660_SPLASHSCREEN
> $(INSTALL) -D -m 0644 boot/grub/splash.xpm.gz \
> - $(ISO9660_TARGET_DIR)/splash.xpm.gz
> + $(ROOTFS_ISO9660_TARGET_DIR)/splash.xpm.gz
> endef
> endif
>
> ifeq ($(BR2_TARGET_ROOTFS_INITRAMFS),y)
> define ROOTFS_ISO9660_INITRD
> - $(SED) '/initrd/d' $(ISO9660_TARGET_DIR)/boot/grub/menu.lst
> + $(SED) '/initrd/d' $(ROOTFS_ISO9660_TARGET_DIR)/boot/grub/menu.lst
> endef
> else
> define ROOTFS_ISO9660_INITRD
> $(INSTALL) -D -m 0644 $(BINARIES_DIR)/rootfs.cpio$(ROOTFS_CPIO_COMPRESS_EXT) \
> - $(ISO9660_TARGET_DIR)/initrd
> + $(ROOTFS_ISO9660_TARGET_DIR)/initrd
> endef
> endif
>
> define ROOTFS_ISO9660_PREPARATION
> $(INSTALL) -D -m 0644 $(GRUB_DIR)/stage2/stage2_eltorito \
> - $(ISO9660_TARGET_DIR)/boot/grub/stage2_eltorito
> - $(INSTALL) -D -m 0644 $(ISO9660_BOOT_MENU) \
> - $(ISO9660_TARGET_DIR)/boot/grub/menu.lst
> - $(INSTALL) -D -m 0644 $(LINUX_IMAGE_PATH) $(ISO9660_TARGET_DIR)/kernel
> + $(ROOTFS_ISO9660_TARGET_DIR)/boot/grub/stage2_eltorito
> + $(INSTALL) -D -m 0644 $(ROOTFS_ISO9660_BOOT_MENU) \
> + $(ROOTFS_ISO9660_TARGET_DIR)/boot/grub/menu.lst
> + $(INSTALL) -D -m 0644 $(LINUX_IMAGE_PATH) $(ROOTFS_ISO9660_TARGET_DIR)/kernel
> $(ROOTFS_ISO9660_SPLASHSCREEN)
> $(ROOTFS_ISO9660_INITRD)
> endef
> @@ -46,11 +46,11 @@ ROOTFS_ISO9660_PRE_GEN_HOOKS += ROOTFS_ISO9660_PREPARATION
> define ROOTFS_ISO9660_CMD
> $(HOST_DIR)/usr/bin/genisoimage -J -R -b boot/grub/stage2_eltorito \
> -no-emul-boot -boot-load-size 4 -boot-info-table \
> - -o $@ $(ISO9660_TARGET_DIR)
> + -o $@ $(ROOTFS_ISO9660_TARGET_DIR)
> endef
>
> define ROOTFS_ISO9660_REMOVE_TEMPDIR
> - $(RM) -rf $(ISO9660_TARGET_DIR)
> + $(RM) -rf $(ROOTFS_ISO9660_TARGET_DIR)
> endef
>
> ROOTFS_ISO9660_POST_GEN_HOOKS += ROOTFS_ISO9660_REMOVE_TEMPDIR
> --
> 2.1.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-06-05 21:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 15:05 [Buildroot] [PATCH 00/12] iso9660 support improvements Thomas Petazzoni
2015-06-04 15:05 ` [Buildroot] [PATCH 01/12] fs/common: add <fs>_POST_GEN_HOOKS support Thomas Petazzoni
2015-06-05 9:43 ` Samuel Martin
2015-06-05 20:49 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 02/12] fs/iso9660: convert to the filesystem infrastructure Thomas Petazzoni
2015-06-05 11:59 ` Samuel Martin
2015-06-05 13:34 ` Thomas Petazzoni
2015-06-05 20:58 ` Yann E. MORIN
2015-06-06 0:42 ` Thomas Petazzoni
2015-06-06 9:01 ` Yann E. MORIN
2015-06-06 14:57 ` Thomas Petazzoni
2015-06-06 16:03 ` Yann E. MORIN
2015-06-05 22:44 ` Arnout Vandecappelle
2015-06-06 0:43 ` Thomas Petazzoni
2015-06-07 19:53 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 03/12] fs/iso9660: use if ... endif block instead of depends on Thomas Petazzoni
2015-06-05 12:01 ` Samuel Martin
2015-06-05 21:00 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 04/12] fs/iso9660: enable Joliet extension Thomas Petazzoni
2015-06-05 12:06 ` Samuel Martin
2015-06-05 21:18 ` Yann E. MORIN
2015-06-06 0:46 ` Thomas Petazzoni
2015-06-06 9:02 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 05/12] fs/iso9660: rename all variables to use the ROOTFS_ISO9660 prefix Thomas Petazzoni
2015-06-05 12:08 ` Samuel Martin
2015-06-05 21:20 ` Yann E. MORIN [this message]
2015-06-04 15:05 ` [Buildroot] [PATCH 06/12] fs/iso9660: change the location of the splash image Thomas Petazzoni
2015-06-05 12:09 ` Samuel Martin
2015-06-05 21:30 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 07/12] fs/iso9660: prepare cleaner kernel/initrd path handling Thomas Petazzoni
2015-06-05 12:11 ` Samuel Martin
2015-06-05 21:43 ` Yann E. MORIN
2015-06-05 22:06 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 08/12] fs/iso9660: support building a real iso9660 filesystem Thomas Petazzoni
2015-06-05 12:57 ` Samuel Martin
2015-06-05 22:13 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 09/12] fs/iso9660: add support for isolinux Thomas Petazzoni
2015-06-05 13:02 ` Samuel Martin
2015-06-05 22:38 ` Yann E. MORIN
2015-06-06 1:03 ` Thomas Petazzoni
2015-06-06 9:25 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 10/12] fs/iso9660: add hybrid image support Thomas Petazzoni
2015-06-05 13:07 ` Samuel Martin
2015-06-05 22:51 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 11/12] grub2: prepare and install El Torito image Thomas Petazzoni
2015-06-05 13:21 ` Samuel Martin
2015-06-05 22:55 ` Yann E. MORIN
2015-06-05 23:09 ` Yann E. MORIN
2015-06-06 0:57 ` Thomas Petazzoni
2015-06-06 9:31 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 12/12] fs/iso9660: add support for grub2 Thomas Petazzoni
2015-06-05 13:30 ` Samuel Martin
2015-06-05 23:07 ` Yann E. MORIN
2015-06-06 0:59 ` Thomas Petazzoni
2015-06-06 9:18 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605212031.GE3641@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.