From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [Patch v2 0/4] Introduce a mechanism to allocate PCI IRQ on demand Date: Fri, 5 Jun 2015 16:24:17 -0500 Message-ID: <20150605212417.GU3631@google.com> References: <1433213360-3700-1-git-send-email-jiang.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ig0-f178.google.com ([209.85.213.178]:37146 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbbFEVYV (ORCPT ); Fri, 5 Jun 2015 17:24:21 -0400 Received: by igbsb11 with SMTP id sb11so23968532igb.0 for ; Fri, 05 Jun 2015 14:24:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1433213360-3700-1-git-send-email-jiang.liu@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jiang Liu Cc: Thomas Gleixner , "Rafael J . Wysocki" , LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, "x86 @ kernel . org" On Tue, Jun 02, 2015 at 10:49:15AM +0800, Jiang Liu wrote: > This patch set introduces a mechanism to allocate PCI IRQ on demand and > free it when not used anymore by hooking pci_device_probe() and > pci_device_remove(). > > It will be used to track IOAPIC pin usage on x86 so we could support > IOAPIC hot-removal. > > The patch set passes Fengguang's 0day test suite. > > V1->V2: > 1) Refine pci_device_probe() to optimize for mainline code as suggested > by Bjorn > 2) Reorder patch set to put optional patch as the last (Patch 4) > > Thanks! > Gerry > > > Jiang Liu (4): > PCI: Add hooks to allocate/free IRQ resources when binding/unbinding > driver > PCI, x86: Allocate PCI IRQ on demand and free it when not used > anymore > PCI: Introduce helpers to manage pci_dev->irq and > pci_dev->irq_managed > PCI, MSI: Optionally free legacy PCI IRQ when enabling MSI/MSI-X > > arch/x86/include/asm/pci_x86.h | 2 -- > arch/x86/pci/common.c | 20 +++++++++----------- > arch/x86/pci/intel_mid_pci.c | 9 ++++++--- > arch/x86/pci/irq.c | 23 ++++------------------- > drivers/acpi/pci_irq.c | 17 ++++------------- > drivers/pci/msi.c | 6 +++++- > drivers/pci/pci-driver.c | 26 ++++++++++++++++++++------ > include/linux/pci.h | 19 +++++++++++++++++++ > 8 files changed, 67 insertions(+), 55 deletions(-) I'm fine with these patches, and I can merge them, but I would like an ack from Thomas. Or, if it makes more sense to route these along with other related patches through Thomas, here's my ack: Acked-by: Bjorn Helgaas