Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-kernel@vger.kernel.org,

[Aparna Karuthodi <kdasaparna@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]


On Sat, Jun 06, 2015 at 02:26:28PM +0530, Aparna wrote:

> From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001
> From: Aparna Karuthodi <kdasaparna@gmail.com>
> Date: Sat, 6 Jun 2015 11:01:16 +0530
> Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary
>  for single statement blocks
> 
> Removed the braces of if else statements which contain only one
> statement
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index f81a375..6cd0b6a 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
>  	 * 3) NONE - Do nothing. Since we didn't do anything to turn off the
>  	 *	other side, we don't need to do anything now.
>  	 */
> -	if (qleft > (RQUEUESIZE / 2)) {
> +	if (qleft > (RQUEUESIZE / 2))
>  		/* HWFLOW */
>  		if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & CRTSCTS) {
>  			if (ch->ch_flags & CH_RECEIVER_OFF) {
> @@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
>  			ch->ch_bd->bd_ops->send_start_character(ch);
>  		}
>  		/* No FLOW */
> -		else {
> +		else 
>  			/* Nothing needed. */
> -		}
> -	}
> +		
> +	
>  }
>  
>  
> -- 
> 1.7.9.5
> 


[-- Attachment #2: 0003-PATCH-staging-dgnc-Fixed-braces-are-not-necessary-fo.patch --]
[-- Type: text/x-diff, Size: 1312 bytes --]

>From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001
From: Aparna Karuthodi <kdasaparna@gmail.com>
Date: Sat, 6 Jun 2015 11:01:16 +0530
Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary
 for single statement blocks

Removed the braces of if else statements which contain only one
statement

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/dgnc/dgnc_tty.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f81a375..6cd0b6a 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
 	 * 3) NONE - Do nothing. Since we didn't do anything to turn off the
 	 *	other side, we don't need to do anything now.
 	 */
-	if (qleft > (RQUEUESIZE / 2)) {
+	if (qleft > (RQUEUESIZE / 2))
 		/* HWFLOW */
 		if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & CRTSCTS) {
 			if (ch->ch_flags & CH_RECEIVER_OFF) {
@@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
 			ch->ch_bd->bd_ops->send_start_character(ch);
 		}
 		/* No FLOW */
-		else {
+		else 
 			/* Nothing needed. */
-		}
-	}
+		
+	
 }
 
 
-- 
1.7.9.5