[Buildroot] [PATCH 12/12] fs/iso9660: add support for grub2

[Yann E. MORIN <yann.morin.1998@free.fr>]

Thomas, All,

On 2015-06-06 02:59 +0200, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
> 
> On Sat, 6 Jun 2015 01:07:56 +0200, Yann E. MORIN wrote:
> 
> > > -comment "iso image needs a Linux kernel and grub or isolinux to be built"
> > > +comment "iso image needs a Linux kernel and grub(2) or isolinux to be built"
> > 
> > I ghave to admit that reading this comment using the usual associativity
> > of 'and' and 'or' makes it sound that we either want
> >   - a kernel and grub/grub2,
> >   - or isolinux
> 
> True. Any suggestion to improve that?
> 
> comment "iso image needs (a Linux kernel && (grub(2) || isolinux))"
> 
> is probably a bit hard to read, no ? :-)

    iso image needs a Linux kernel and one of grub, grub2 or isolinux

> > > +menuentry "Buildroot" {
> > > +	linux __KERNEL_PATH__ root=/dev/sr0 console=tty1
> > 
> > Why do you forcibly pass the console setting?
> 
> That's a good question. We don't have that for the grub and isolinux
> case, so I'm not sure why I added that for the grub2 case. I'll kill
> that and retest. Thanks for noticing!

He! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'