From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
Brian Gerst <brgerst@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH] Rename ia32entry.S to entry_64_compat_32.S
Date: Sun, 7 Jun 2015 14:58:16 +0200 [thread overview]
Message-ID: <20150607125816.GA6335@gmail.com> (raw)
In-Reply-To: <CALCETrU5+2epG3cZnZy2qwg_WSr+Cd1u8jjSXWFuaK+YPa7EmA@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> On Fri, Jun 5, 2015 at 2:09 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> > Call it sys if it is now only the system call entry points. Agreed with _64_compat too.
> >
> > Breaking up these snarls of spaghetti assembly will be a blessing.
>
> I'm not too picky about what we call it or whether we merge it with entry_64.S.
> *However*, I think the file name should end in _64.S. The whole arch/x86 tree is
> arranged such that files that end in _64.S or _64.c are build for 64-bit kernels
> and not for 32-bit kernels. I see no reason to deviate from that.
>
> FWIW, I'm eventually planning to completely rewrite the compat entry points to
> use the new (RFC patches coming in a week or two I hope!) C exit code with
> opportunistic sysretl at the end. I'm guessing the result will be about half
> the size of the current code, and it'll be comprehensible to mere mortals.
Ok, so I think the best is if I leave it alone for now: I've renamed it to
entry_64_compat.S as per Boris's and hpa's suggestion, but won't merge it into
entry_64.S (yet), let's see how your C conversion works out!
Thanks,
Ingo
prev parent reply other threads:[~2015-06-07 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 13:00 [RFC PATCH] Rename ia32entry.S to entry_64_compat_32.S Ingo Molnar
2015-06-05 13:00 ` [PATCH] x86/asm/entry/64/compat: Rename ia32entry.S -> entry_64_compat_32.S Ingo Molnar
2015-06-05 14:02 ` Brian Gerst
2015-06-05 13:37 ` [RFC PATCH] Rename ia32entry.S to entry_64_compat_32.S Borislav Petkov
2015-06-05 21:09 ` H. Peter Anvin
2015-06-05 21:37 ` Andy Lutomirski
2015-06-07 12:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150607125816.GA6335@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.