From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][v2] drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect
Date: Sun, 7 Jun 2015 15:45:47 +0200 [thread overview]
Message-ID: <201506071545.48042.marex@denx.de> (raw)
In-Reply-To: <1433660284-10477-1-git-send-email-nikhil.badola@freescale.com>
On Sunday, June 07, 2015 at 08:58:04 AM, Nikhil Badola wrote:
> Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller
> to be initialised is incorrect
This text doesn't really make much sense, but the fix is reasonable.
I'll pick it, thanks!
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Changes for v2
> - Added space between tags in Subject
> - Replaced return value from -1 to -EINVAL
>
> drivers/usb/host/ehci-fsl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 5fd618d..97b7f14 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
> break;
> default:
> printf("ERROR: wrong controller index!!\n");
> - break;
> + return -EINVAL;
> };
>
> *hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
Best regards,
Marek Vasut
prev parent reply other threads:[~2015-06-07 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-07 6:58 [U-Boot] [PATCH][v2] drivers: usb: fsl: Return if USB_MAX_CONTROLLER_COUNT is incorrect Nikhil Badola
2015-06-07 13:45 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201506071545.48042.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.