All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Ingo Molnar <mingo@kernel.org>, Andi Kleen <ak@linux.intel.com>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCHv3] perf stat: Add id into perf_stat struct
Date: Mon, 8 Jun 2015 11:03:40 -0300	[thread overview]
Message-ID: <20150608140340.GC3136@kernel.org> (raw)
In-Reply-To: <20150604135055.GB23625@krava.redhat.com>

Em Thu, Jun 04, 2015 at 03:50:55PM +0200, Jiri Olsa escreveu:
> On Wed, Jun 03, 2015 at 04:25:51PM +0200, Jiri Olsa wrote:
> > We need fast way to identify evsel as transaction event
> > for shadow counters computation. Currently we are using
> > possition (in evlist) based way.
> > 
> > Adding 'id' into 'struct perf_stat' so it can carry transaction
> > event ID and we can use it for shadow counters computations.
> > 
> > Link: http://lkml.kernel.org/n/tip-9lnvjksibrs0flhkpix2qkm9@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> 
> using perf_evsel__name instead of evsel->name pointer

It now passes 'perf test' on rhel7/fedora21 systems, but it fails on a
rhel6 system, I applied it, will test it further on the rhel6 system to
see what went wrong there, unless you do it first ;-)

[root@sandy ~]# perf test 15
15: struct perf_event_attr setup                             :sh: line
1:  5381 Aborted                 (core dumped)
PERF_TEST_ATTR=/tmp/tmp8ZBLwc /home/acme/bin/perf stat -o
/tmp/tmp8ZBLwc/perf.data --group -e cycles,instructions kill > /dev/null
2>&1
sh: line 1:  5438 Aborted                 (core dumped)
PERF_TEST_ATTR=/tmp/tmpnRDADB /home/acme/bin/perf stat -o
/tmp/tmpnRDADB/perf.data -e '{cycles,instructions}' kill > /dev/null
2>&1
 Ok
[root@sandy ~]# uname -r
2.6.32-504.8.1.el6.x86_64
[root@sandy ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 6.6 (Santiago)
[root@sandy ~]# 

- Arnaldo



  reply	other threads:[~2015-06-08 14:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 14:25 [PATCHv2 0/9] perf stat: Separate shadow counters code Jiri Olsa
2015-06-03 14:25 ` [PATCH 1/9] perf stat: Add id into perf_stat struct Jiri Olsa
2015-06-04 13:50   ` [PATCHv3] " Jiri Olsa
2015-06-08 14:03     ` Arnaldo Carvalho de Melo [this message]
2015-06-09 20:09       ` Jiri Olsa
2015-06-09  9:48     ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 14:25 ` [PATCH 2/9] perf stat: Replace transaction event possition check with id check Jiri Olsa
2015-06-09  9:49   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 14:25 ` [PATCH 3/9] perf stat: Remove setup_events function Jiri Olsa
2015-06-09  9:49   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 14:25 ` [PATCH 4/9] perf stat: Remove transaction_run from shadow update/print code Jiri Olsa
2015-06-03 15:10   ` Arnaldo Carvalho de Melo
2015-06-03 15:14     ` Jiri Olsa
2015-06-03 15:55       ` Arnaldo Carvalho de Melo
2015-06-09  9:49   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 14:25 ` [PATCH 5/9] perf stat: Introduce reset_shadow_stats function Jiri Olsa
2015-06-09  9:50   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 14:25 ` [PATCH 6/9] perf stat: Introduce print_shadow_stats function Jiri Olsa
2015-06-09  9:50   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 14:25 ` [PATCH 7/9] perf stat: Add output file argument to " Jiri Olsa
2015-06-09  9:50   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 14:25 ` [PATCH 8/9] perf stat: Add aggr_mode " Jiri Olsa
2015-06-09  9:51   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 14:25 ` [PATCH 9/9] perf stat: Move shadow stat counters into separate object Jiri Olsa
2015-06-09  9:51   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-03 22:07 ` [PATCHv2 0/9] perf stat: Separate shadow counters code Arnaldo Carvalho de Melo
2015-06-03 22:24   ` Arnaldo Carvalho de Melo
2015-06-03 22:38     ` Jiri Olsa
2015-06-03 22:42       ` Arnaldo Carvalho de Melo
2015-06-04 13:49         ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150608140340.GC3136@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.