From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v11 04/10] iommu/vt-d: functions to copy data from old mem Date: Mon, 8 Jun 2015 17:21:47 +0200 Message-ID: <20150608152147.GV20384@8bytes.org> References: <1431337974-545-1-git-send-email-zhen-hual@hp.com> <1431337974-545-5-git-send-email-zhen-hual@hp.com> <1433772935.2952.47.camel@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1433772935.2952.47.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: David Woodhouse Cc: bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, tom.vaden-VXdhtT5mjnY@public.gmane.org, rwright-VXdhtT5mjnY@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lisa.mitchell-VXdhtT5mjnY@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "Li, Zhen-Hua" , doug.hatch-VXdhtT5mjnY@public.gmane.org, ishii.hironobu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, billsumnerlinux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, li.zhang6-VXdhtT5mjnY@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: iommu@lists.linux-foundation.org SGkgRGF2aWQsCgpPbiBNb24sIEp1biAwOCwgMjAxNSBhdCAwMzoxNTozNVBNICswMTAwLCBEYXZp ZCBXb29kaG91c2Ugd3JvdGU6Cj4gU3VyZWx5IHRoaXMgaXNuJ3Qgc3BlY2lmaWMgdG8gdGhlIElu dGVsIElPTU1VPyBTaG91bGRuJ3QgaXQgbGl2ZQo+IGVsc2V3aGVyZSDigJQgZWl0aGVyIGluIGdl bmVyaWMgSU9NTVUgY29kZSBvciBwZXJoYXBzIGluIGdlbmVyaWMga2V4ZWMKPiBzdXBwb3J0IGNv ZGU/CgpJIHB1dCBhIGJpZ2dlciByZXdvcmsgb2YgdGhpcyBvbi10b3Agb2YgWmhlbi1IdWEncyBw YXRjaGVzLCB5b3UgY2FuIGZpbmQKdGhlIHJlc3VsdCBpbiBteSB4ODYvdnQtZCBicmFuY2guIFdp dGggbXkgcGF0Y2hlcyBJIGFsc28gcmVtb3ZlZCB0aGlzCnBvaW50ZXIgY29sbGVjdGluZyBjb25j ZXB0IGFuZCBkbyB0aGUgaW9tYXBfY2FjaGUgYW5kIGlvdW5tYXAgY2FsbHMKYmVmb3JlIHRoZSBz cGluLWxvY2sgaXMgdGFrZW4sIHNvIHRoaXMgcHJvYmxlbSBpcyBub3cgc29sdmVkCmRpZmZlcmVu dGx5LgoKPiBBbmQgSSB0aGluayB5b3UncmUgbWlzdXNpbmcgVlREX1BBR0Vfe1NISUZULE1BU0t9 IHdoZW4geW91IHNob3VsZCBiZQo+IHVzaW5nIHRoZSBub3JtYWwgUEFHRV97U0hJRlQsTUFTS30u CgpJIHRoaW5rIFZUX1BBR0VfKiBpcyBjb3JyZWN0LCBzaW5jZSB0aGUgVlQtZCBkcml2ZXIgYWxz byBydW5zIG9uIGlhNjQuClRoZXJlIHRoZSBzeXN0ZW0gcGFnZS1zaXplIGlzIGRpZmZlcmVudCBm cm9tIHRoZSBWVC1kIHBhZ2Utc2l6ZS4KCj5BbmQgc2hvdWxkbid0IHBoeXNpY2FsIGFkZHJlc3Nl cyBiZSBwaHlzX2FkZHJfdD8KClRoaXMgaXMgY2hhbmdlZCB3aGVyZSBhcHByb3ByaWF0ZSwgSSBo b3BlLgoKCglKb2VyZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3Jn Cmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 8bytes.org ([81.169.241.247]:44069 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752913AbbFHPVt (ORCPT ); Mon, 8 Jun 2015 11:21:49 -0400 Date: Mon, 8 Jun 2015 17:21:47 +0200 From: Joerg Roedel To: David Woodhouse Cc: "Li, Zhen-Hua" , indou.takao@jp.fujitsu.com, bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, kexec@lists.infradead.org, alex.williamson@redhat.com, ddutile@redhat.com, ishii.hironobu@jp.fujitsu.com, bhelgaas@google.com, doug.hatch@hp.com, jerry.hoemann@hp.com, tom.vaden@hp.com, li.zhang6@hp.com, lisa.mitchell@hp.com, billsumnerlinux@gmail.com, rwright@hp.com Subject: Re: [PATCH v11 04/10] iommu/vt-d: functions to copy data from old mem Message-ID: <20150608152147.GV20384@8bytes.org> References: <1431337974-545-1-git-send-email-zhen-hual@hp.com> <1431337974-545-5-git-send-email-zhen-hual@hp.com> <1433772935.2952.47.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1433772935.2952.47.camel@infradead.org> Sender: linux-pci-owner@vger.kernel.org List-ID: Hi David, On Mon, Jun 08, 2015 at 03:15:35PM +0100, David Woodhouse wrote: > Surely this isn't specific to the Intel IOMMU? Shouldn't it live > elsewhere — either in generic IOMMU code or perhaps in generic kexec > support code? I put a bigger rework of this on-top of Zhen-Hua's patches, you can find the result in my x86/vt-d branch. With my patches I also removed this pointer collecting concept and do the iomap_cache and iounmap calls before the spin-lock is taken, so this problem is now solved differently. > And I think you're misusing VTD_PAGE_{SHIFT,MASK} when you should be > using the normal PAGE_{SHIFT,MASK}. I think VT_PAGE_* is correct, since the VT-d driver also runs on ia64. There the system page-size is different from the VT-d page-size. >And shouldn't physical addresses be phys_addr_t? This is changed where appropriate, I hope. Joerg