From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3 2/3] ext4: Try to initialize all groups we can in case of failure on ppc64
Date: Mon, 8 Jun 2015 11:39:21 -0400 [thread overview]
Message-ID: <20150608153921.GE19168@thunk.org> (raw)
In-Reply-To: <1433266205-24513-2-git-send-email-lczerner@redhat.com>
On Tue, Jun 02, 2015 at 07:30:04PM +0200, Lukas Czerner wrote:
> Currently on the machines with page size > block size when initializing
> block group buddy cache we initialize it for all the block group bitmaps
> in the page. However in the case of read error, checksum error, or if
> a single bitmap is in any way corrupted we would fail to initialize all
> of the bitmaps. This is problematic because we will not have access to
> the other allocation groups even though those might be perfectly fine
> and usable.
>
> Fix this by reading all the bitmaps instead of error out on the first
> problem and simply skip the bitmaps which were either not read properly,
> or are not valid.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2015-06-08 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 17:30 [PATCH v3 1/3] ext4: Verify block bitmap even after fresh initialization Lukas Czerner
2015-06-02 17:30 ` [PATCH v3 2/3] ext4: Try to initialize all groups we can in case of failure on ppc64 Lukas Czerner
2015-06-08 15:39 ` Theodore Ts'o [this message]
2015-06-02 17:30 ` [PATCH v3 3/3] ext4: Return error code from ext4_mb_good_group() Lukas Czerner
2015-06-08 15:42 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608153921.GE19168@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.