From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: David Moore <dmoorefo@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: BUG_ON assertion repeated for inode1, not done for inode2
Date: Mon, 8 Jun 2015 11:59:37 -0400 [thread overview]
Message-ID: <20150608155937.GH19168@thunk.org> (raw)
In-Reply-To: <5564DB28.1050908@redhat.com>
On Tue, May 26, 2015 at 03:44:24PM -0500, Eric Sandeen wrote:
> On 5/26/15 12:42 PM, David Moore wrote:
> > During a source code review of fs/ext4/extents.c I noted identical
> > consecutive lines. An assertion is repeated for inode1 and never done
> > for inode2. This is not in keeping with the rest of the code in the
> > ext4_swap_extents function and appears to be a bug.
> >
> > Assert that the inode2 mutex is not locked.
>
> Yep, it's been that way since
>
> fcf6b1b ext4: refactor ext4_move_extents code base
>
> and it's pretty obviously not right as it is, and
> if there's any doubt the comments make it clear:
>
> + * Locking:
> + * i_mutex is held for both inodes
> + * i_data_sem is locked for write for both inodes
>
> Thanks,
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2015-06-08 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 17:42 [PATCH] ext4: BUG_ON assertion repeated for inode1, not done for inode2 David Moore
2015-05-26 20:44 ` Eric Sandeen
2015-06-08 15:59 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608155937.GH19168@thunk.org \
--to=tytso@mit.edu \
--cc=dmoorefo@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.