From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH 0/5] HID: wacom: Support tablets with pen and touch on same interface Date: Mon, 8 Jun 2015 11:59:47 -0400 Message-ID: <20150608155947.GD18162@mail.corp.redhat.com> References: <1433380697-28612-1-git-send-email-killertofu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51620 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbbFHP7u (ORCPT ); Mon, 8 Jun 2015 11:59:50 -0400 Content-Disposition: inline In-Reply-To: <1433380697-28612-1-git-send-email-killertofu@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jason Gerecke Cc: Ping Cheng , Aaron Skomra , Jiri Kosina , linux-input@vger.kernel.org, Jason Gerecke Hi again, On Jun 03 2015 or thereabouts, Jason Gerecke wrote: > I've recently got my hands on a device which has an I2C sensor that sends > both pen and touch reports from a single interface. To userspace, it shows > up as a single input device which blends both the report types (e.g. it has > ABS_PRESSURE for the pen, and ABS_MT_POSITION_X for the touch). This patch > set modifies the driver to be able to handle devices which place both pen > and touch on a the same interface. It does this by treating the pen, touch, > and pad (which was already special-cased) independently. If a device has > the appropriate device_type, one or more of pen/touch/pad input devices > will be created, initialized, and used to send data to userspace. > > Signed-off-by: Jason Gerecke So, besides the typo in 5/5, the series is: Reviewed-by: Bnejamin Tissoires I'll send a follow up patch to fix the Bamboo PAD extra interface once this will land in Jiri's tree. Cheers, Benjamin > > Jason Gerecke (5): > HID: wacom: Simplify 'wacom_update_name' > HID: wacom: Treat features->device_type values as flags > HID: wacom: Introduce a new WACOM_DEVICETYPE_PAD device_type > HID: wacom: Split apart 'wacom_setup_pentouch_input_capabilites' > HID: wacom: Introduce new 'touch_input' device > > drivers/hid/wacom.h | 4 +- > drivers/hid/wacom_sys.c | 194 +++++++++++++++---------- > drivers/hid/wacom_wac.c | 379 ++++++++++++++++++++++++++---------------------- > drivers/hid/wacom_wac.h | 15 +- > 4 files changed, 332 insertions(+), 260 deletions(-) > > -- > 2.4.1 >