From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1Z20HC-0001uZ-88
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:51:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1Z20H7-0000Hu-8f
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:51:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55271)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1Z20H7-0000HR-3R
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 12:51:49 -0400
Date: Mon, 8 Jun 2015 17:51:46 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20150608165146.GA29283@redhat.com>
References: <1433782047-7939-1-git-send-email-kchamart@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433782047-7939-1-git-send-email-kchamart@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-sanity-check.in: Use '-display none'
 instead of '-nographic'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kashyap Chamarthy <kchamart@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

On Mon, Jun 08, 2015 at 06:47:00PM +0200, Kashyap Chamarthy wrote:
> Upstream QEMU recommends to use '-display none' as opposed to
> '-nographic' -- which is a "legacy option that does a whole bunch of
> confusing stuff" (thanks Peter Maydell).
> 
> Upstream libguestfs already made the switch [1] in DEC-2013.
> 
> [1] https://github.com/libguestfs/libguestfs/commit/7a41f5c1 -- "launch:
>     switch from -nographic to -display none "
> ---
>  qemu-sanity-check.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-sanity-check.in b/qemu-sanity-check.in
> index 5bb5b292def5caff5ca63071565bd447cf5f4efd..34cd9385f56b5eedd0ec26abd128232a47e51996 100644
> --- a/qemu-sanity-check.in
> +++ b/qemu-sanity-check.in
> @@ -140,7 +140,8 @@ test_output="$(mktemp --suff=.out)"
>  declare -a argv
>  i=0
>  argv[$((i++))]="$qemu"
> -argv[$((i++))]="-nographic"
> +argv[$((i++))]="-display"
> +argv[$((i++))]="none"
>  argv[$((i++))]="-nodefconfig"
>  argv[$((i++))]="-nodefaults"
>  argv[$((i++))]="-machine"
> -- 
> 2.1.0

Thanks -- I have pushed this patch upstream.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html