From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Arjun AK <arjunak234@gmail.com>, Greg Donald <gdonald@gmail.com>,
Darshana Padmadas <darshanapadmadas@gmail.com>,
Joe Perches <joe@perches.com>,
HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning
Date: Mon, 8 Jun 2015 12:35:14 -0700 [thread overview]
Message-ID: <20150608193514.GA1044@kroah.com> (raw)
In-Reply-To: <1433362810-14176-1-git-send-email-tolga.ceylan@gmail.com>
On Wed, Jun 03, 2015 at 01:20:10PM -0700, Tolga Ceylan wrote:
> In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
> warning due its inability to detect the noreturn attribute in
> lbug_with_lock() function inside LBUG macro. With this patch, we unlock
> the spinlock before checking the error condition to resolve this warning.
That's a bug in sparse, not in the code, please don't work around tool
bugs by changing kernel code.
thanks,
greg k-h
next prev parent reply other threads:[~2015-06-08 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 20:20 [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning Tolga Ceylan
2015-06-08 19:35 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-02 19:57 Tolga Ceylan
2015-06-03 6:42 ` Sudip Mukherjee
2015-06-03 15:47 ` Tolga Ceylan
2015-06-03 16:36 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608193514.GA1044@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=arjunak234@gmail.com \
--cc=darshanapadmadas@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.