From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] debugfs: support read-only and write-only bool types
Date: Mon, 8 Jun 2015 13:57:03 -0700 [thread overview]
Message-ID: <20150608205703.GC11211@kroah.com> (raw)
In-Reply-To: <20150605164255.GV14071@sirena.org.uk>
On Fri, Jun 05, 2015 at 05:42:55PM +0100, Mark Brown wrote:
> On Fri, Jun 05, 2015 at 03:34:45PM +0100, Richard Fitzgerald wrote:
>
> > +static ssize_t debugs_read_wo_file(struct file *file, char __user *buf,
> > + size_t count, loff_t *ppos)
> > +{
> > + return -EACCES;
> > +}
>
> Perhaps I'm missing something but shouldn't we be able to just omit
> empty functions like this (this seems to be what the other ro/wo debugfs
> defintions do otherwise these would already be there and it's what I'd
> expect)?
Yes you should.
next prev parent reply other threads:[~2015-06-08 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 14:34 [PATCH 0/2] debugfs: support read-only and write-only bool types Richard Fitzgerald
2015-06-05 14:34 ` [PATCH 1/2] " Richard Fitzgerald
2015-06-05 16:42 ` Mark Brown
2015-06-08 20:57 ` Greg KH [this message]
2015-06-05 14:34 ` [PATCH 2/2] regmap: Fix permissions on debugfs cache controls Richard Fitzgerald
2015-06-05 15:25 ` Mark Brown
2015-06-05 15:53 ` Richard Fitzgerald
2015-06-05 16:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608205703.GC11211@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.