From mboxrd@z Thu Jan 1 00:00:00 1970 From: "hch-jcswGhMUV9g@public.gmane.org" Subject: Re: [PATCH v5 09/21] libnvdimm, nd_pmem: add libnvdimm support to the pmem driver Date: Tue, 9 Jun 2015 08:36:57 +0200 Message-ID: <20150609063657.GC9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001458.4506.76492.stgit@dwillia2-desk3.amr.corp.intel.com> <20150603074424.GA24949@infradead.org> <1433359894.21035.33.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1433359894.21035.33.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Williams, Dan J" Cc: "hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org" , "neilb-l3A5Bk7waGM@public.gmane.org" , "linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "hch-jcswGhMUV9g@public.gmane.org" , "axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org" , "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org" , "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" , "rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-api@vger.kernel.org On Wed, Jun 03, 2015 at 07:31:38PM +0000, Williams, Dan J wrote: > I like move-modify patches because they make the reason for the move > clearer and revertible. Consider a general case where we later decide > the reason for a move was invalid. Reverting the reason also reverts > the file move, that doesn't automatically happen when it is split to > another commit. BS. A move is never fundamentally related to the change. Your series would work perfectly fine without the move for example. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932541AbbFIGhF (ORCPT ); Tue, 9 Jun 2015 02:37:05 -0400 Received: from verein.lst.de ([213.95.11.211]:45989 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932330AbbFIGg7 (ORCPT ); Tue, 9 Jun 2015 02:36:59 -0400 Date: Tue, 9 Jun 2015 08:36:57 +0200 From: "hch@lst.de" To: "Williams, Dan J" Cc: "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "linux-nvdimm@ml01.01.org" , "neilb@suse.de" , "linux-api@vger.kernel.org" , "hch@lst.de" , "axboe@kernel.dk" , "akpm@linux-foundation.org" , "sfr@canb.auug.org.au" , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH v5 09/21] libnvdimm, nd_pmem: add libnvdimm support to the pmem driver Message-ID: <20150609063657.GC9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001458.4506.76492.stgit@dwillia2-desk3.amr.corp.intel.com> <20150603074424.GA24949@infradead.org> <1433359894.21035.33.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433359894.21035.33.camel@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2015 at 07:31:38PM +0000, Williams, Dan J wrote: > I like move-modify patches because they make the reason for the move > clearer and revertible. Consider a general case where we later decide > the reason for a move was invalid. Reverting the reason also reverts > the file move, that doesn't automatically happen when it is split to > another commit. BS. A move is never fundamentally related to the change. Your series would work perfectly fine without the move for example.