From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate Date: Tue, 9 Jun 2015 08:39:00 +0200 Message-ID: <20150609063900.GD9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001514.4506.13974.stgit@dwillia2-desk3.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150602001514.4506.13974.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Williams Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org, rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, neilb-l3A5Bk7waGM@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, hch-jcswGhMUV9g@public.gmane.org List-Id: linux-api@vger.kernel.org > +#include > + > +#ifndef __io_virt > +#define __io_virt(x) ((void __force *) (x)) > +#endif NAK. driver code mus never include asm-generic headers directly, and __io_virt isn't something that's up to a driver to redefine either. I think we really need the memremap series in first before trying to do the things done in this patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 9 Jun 2015 08:39:00 +0200 From: Christoph Hellwig Subject: Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate Message-ID: <20150609063900.GD9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001514.4506.13974.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150602001514.4506.13974.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Dan Williams Cc: linux-nvdimm@lists.01.org, axboe@kernel.dk, sfr@canb.auug.org.au, rafael@kernel.org, neilb@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-api@vger.kernel.org, akpm@linux-foundation.org, hch@lst.de List-ID: > +#include > + > +#ifndef __io_virt > +#define __io_virt(x) ((void __force *) (x)) > +#endif NAK. driver code mus never include asm-generic headers directly, and __io_virt isn't something that's up to a driver to redefine either. I think we really need the memremap series in first before trying to do the things done in this patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753726AbbFIGjN (ORCPT ); Tue, 9 Jun 2015 02:39:13 -0400 Received: from verein.lst.de ([213.95.11.211]:46006 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbbFIGjD (ORCPT ); Tue, 9 Jun 2015 02:39:03 -0400 Date: Tue, 9 Jun 2015 08:39:00 +0200 From: Christoph Hellwig To: Dan Williams Cc: linux-nvdimm@ml01.01.org, axboe@kernel.dk, sfr@canb.auug.org.au, rafael@kernel.org, neilb@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-api@vger.kernel.org, akpm@linux-foundation.org, hch@lst.de Subject: Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate Message-ID: <20150609063900.GD9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001514.4506.13974.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150602001514.4506.13974.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +#include > + > +#ifndef __io_virt > +#define __io_virt(x) ((void __force *) (x)) > +#endif NAK. driver code mus never include asm-generic headers directly, and __io_virt isn't something that's up to a driver to redefine either. I think we really need the memremap series in first before trying to do the things done in this patch.