From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: Add display timing for Okaya RS800480T-7X0GP Date: Tue, 9 Jun 2015 09:22:11 +0200 Message-ID: <20150609072208.GA28064@ulmo> References: <1432827466-8104-1-git-send-email-gary.bisson@boundarydevices.com> <20150605122809.GB759@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1967152692==" Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 860606E747 for ; Tue, 9 Jun 2015 00:22:41 -0700 (PDT) Received: by wiga1 with SMTP id a1so6845222wig.0 for ; Tue, 09 Jun 2015 00:22:40 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gary Bisson Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1967152692== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 06, 2015 at 11:00:21PM +0200, Gary Bisson wrote: > Thierry, All, >=20 > On Fri, Jun 5, 2015 at 2:28 PM, Thierry Reding = wrote: > > On Thu, May 28, 2015 at 05:37:46PM +0200, Gary Bisson wrote: > >> Add support for the Okaya RS800480T-7X0GP to the DRM simple panel > >> driver. > >> > >> The RS800480T-7X0GP is a WVGA (800x480) panel with an 18-bit parallel > >> LCD interface. It supports pixel clocks in the range of 30-40 MHz. > >> > >> This panel details can be found at: > >> http://boundarydevices.com/product/7-800x480-display/ > >> > >> Signed-off-by: Gary Bisson > >> --- > >> Hi all, > >> > >> This patch is the follow-up of a request from Philipp to add the Okaya= display > >> to the simple panel driver. > >> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/346657.= html > >> > >> Regards, > >> Gary > >> --- > >> .../bindings/panel/okaya,rs800480t_7x0gp.txt | 7 ++++++ > >> .../devicetree/bindings/vendor-prefixes.txt | 1 + > >> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++= +++++++++ > >> 3 files changed, 35 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/panel/okaya,rs80= 0480t_7x0gp.txt > >> > >> diff --git a/Documentation/devicetree/bindings/panel/okaya,rs800480t_7= x0gp.txt b/Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0gp.txt > >> new file mode 100644 > >> index 0000000..f7c729d > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0gp.txt > >> @@ -0,0 +1,7 @@ > >> +OKAYA Electric America, Inc. RS800480T-7X0GP 7" WVGA LCD panel > >> + > >> +Required properties: > >> +- compatible: should be "okaya,rs800480t_7x0gp" > >> + > >> +This binding is compatible with the simple-panel binding, which is sp= ecified > >> +in simple-panel.txt in this directory. > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/D= ocumentation/devicetree/bindings/vendor-prefixes.txt > >> index 4f35a00..06ce91c 100644 > >> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > >> @@ -145,6 +145,7 @@ nintendo Nintendo > >> nokia Nokia > >> nvidia NVIDIA > >> nxp NXP Semiconductors > >> +okaya OKAYA Electric America, Inc. > >> onnn ON Semiconductor Corp. > >> opencores OpenCores.org > >> ortustech Ortus Technology Co., Ltd. > > > > Can you split this change into a separate patch? It needs an Acked-by > > from one of the device tree binding maintainers, so make sure to Cc them > > when you repost. scripts/get_maintainer.pl will list them for you. >=20 > Sure, will do. >=20 > >> +static const struct display_timing okaya_rs800480t_7x0gp_timing =3D { > >> + .pixelclock =3D { 30000000, 30000000, 40000000 }, > >> + .hactive =3D { 800, 800, 800 }, > >> + .hfront_porch =3D { 40, 40, 40 }, > >> + .hback_porch =3D { 40, 40, 40 }, > >> + .hsync_len =3D { 1, 48, 48 }, > >> + .vactive =3D { 480, 480, 480 }, > >> + .vfront_porch =3D { 13, 13, 13 }, > >> + .vback_porch =3D { 29, 29, 29 }, > >> + .vsync_len =3D { 3, 3, 3 }, > > > > It strikes me as odd that the porches and VSYNC width should be fixed > > for the panel. Is this really the case? >=20 > Well this is the values provided by Okaya. Here is a link to the > datasheet, details are located in page 8: > http://boundarydevices.com/datasheets/RS800480T-7X0GP-A.pdf The way I read this the cells marked with - don't specify that a value is the same as typical but rather that nobody determined that value. It's unfortunate because it doesn't give us a good specification of the timings, but I would suspect that the panel operates perfectly fine if you use porches and sync pulse widths outside of the above range. That said, I think it's fine to go with the above until we encounter display hardware that can't match these constraints. Thierry --VS++wcV0S1rZb1Fb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVdpQdAAoJEN0jrNd/PrOhfM4QALSV8L6PAJYjhdEz+2sb8keN ViaM9nXPsOrUqOPKadsWWPjbAemo/zRuxTeUHB6aNSqyMbvnDhjQ6aassb+Rw84L YeCiedKB3MkQUD0g1M6te9OWDdkQEXFM1zLalQfbYP66WNzC3nCPLv10nRTr9yXv JaWuRC0vOfxelEP3ea45QIOUuEb8novtO7d0VhnQFNeO49WMazwfoJdaSTrG7J23 NnHpN65lOCbgkMFSG1RYxJdmp8V8DkRdFwBTakWV+gHidKv09G6sE+r37off8+mt h5YUL5cBx5mvtdmnLslRwyquGGbdwY6+iU6gmolDtPwf75HVtcDcwOptrsmPuzrM Uwka/vo3MFFpTiwx57vPrAI8DmrAMCMJ+G7QqPB4T3UEKz/VzhDnOTSPgDdpul7Q qrqgGnqyjNfB7IC7tZxv6ix5fX6n3BtePFCe3EYzkfnt0z2mVQxC9aeaobtxqjmV E6LDceH3urvl8pIiTAPaXoFMcZW0wPO5blhCSX0+ZvDRln39cwxgoowvfV29dnVR EgFNAGrs3A/6VufT469WzCZVmhZ+Vceio92dDR0AXj/GrRgxU7f3daDXzzrEQ6sE MCYnCaueo3k3xa1BYjIVRlbeGSOW2Gfoh+xlKVC81Aga70snmCCyqKvjyRE8epLg QGxoGpj33abgfKHdJjyL =p+2J -----END PGP SIGNATURE----- --VS++wcV0S1rZb1Fb-- --===============1967152692== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1967152692==--