From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932973AbbFIKJJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Jun 2015 06:09:09 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43095 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932175AbbFIKIw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Jun 2015 06:08:52 -0400
Date: Tue, 9 Jun 2015 12:08:46 +0200
From: Borislav Petkov <bp@suse.de>
To: Huang Rui <ray.huang@amd.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker <fweisbec@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Fengguang Wu <fengguang.wu@intel.com>, Aaron Lu <aaron.lu@intel.com>,
        "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
        "Li, Tony" <Tony.Li@amd.com>, "Xue, Ken" <Ken.Xue@amd.com>
Subject: Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable
Message-ID: <20150609100846.GE22105@pd.tnic>
References: <1433819621-15093-1-git-send-email-ray.huang@amd.com>
 <1433819621-15093-3-git-send-email-ray.huang@amd.com>
 <20150609090543.GA22105@pd.tnic>
 <20150609100309.GB17030@hr-slim.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150609100309.GB17030@hr-slim.amd.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 09, 2015 at 06:03:10PM +0800, Huang Rui wrote:
> Sorry, I am suggested to make the mwaitx delay configurable firstly by
> our guys...
> Why do you think that method is bad?

You're seriously asking that?! Think about it. Who do you think will go
and put "mwaitx" in her/his kernel command line? What percentage of the
users will know that? How are you going to communicate this to all CZ
users?

What does that kernel parameter bring you that you cannot do in code at
boot time?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--