From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
ian.jackson@eu.citrix.com
Subject: Re: [PATCH OSSTEST v2] Stubdom test case
Date: Tue, 9 Jun 2015 11:51:31 +0100 [thread overview]
Message-ID: <20150609105131.GN29102@zion.uk.xensource.com> (raw)
In-Reply-To: <1433846195.7108.536.camel@citrix.com>
On Tue, Jun 09, 2015 at 11:36:35AM +0100, Ian Campbell wrote:
> On Mon, 2015-06-08 at 20:54 +0100, Wei Liu wrote:
> > Currently only QEMU traditional supports stubdom, so we only create
> >
> > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64
> > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm
> > test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64
> > test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm
> >
> > Note that stubdom only supports serial='pty'. Piping serial to stderr
> > causes stubdom to exit abnormally.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > Changes in v2:
> > 1. Don't set stubdom runvar for every test case.
>
> >From the list of runvars I don't think this happened correctly:
>
> > +xen-unstable test-amd64-amd64-xl-qemut-debianhvm-amd64 enable_stubdom false
> > +xen-unstable test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm enable_stubdom false
>
> etc etc
>
> Also:
>
> > +xen-unstable test-amd64-amd64-xl-qemuu-debianhvm-amd64 enable_stubdom
> > +xen-unstable test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm enable_stubdom
> > +xen-unstable test-amd64-amd64-xl-qemuu-ovmf-amd64 enable_stubdom
>
> I don't think is desired.
>
> > + stubdom_suffix="";
> > + if [ x$stubdom = xtrue ]; then
> > + stubdom_suffix="-stubdom"
> > + fi
> > +
> > + job_create_test test-$xenarch$kern-$dom0arch-xl$qemuu_suffix$stubdom_suffix-$testname-amd64\
> > test-debianhvm xl $xenarch $dom0arch $qemuu_runvar \
> > enable_xsm=$xsm \
> > + enable_stubdom=$stubdom \
>
> if [ x$stubdom != x ] ; then
> stubdom_runvar="enable_stubdom=$stubdom"
> fi
>
> Then just pass $stubdom_runvar to job_create_test, this arranges that
> enable_stubdom is only set if a specific value is requested.
>
> > + for stubdom in true false ; do
>
> for stubdom in true '' ; do
>
> then arranges to pass the right things into the above. May need more or
> less quoting when $stubdom is used now.
>
I made the changes you suggested. Now the diff looks like:
--- /dev/fd/63 2015-06-09 11:49:57.242809774 +0100
+++ /dev/fd/62 2015-06-09 11:49:57.242809774 +0100
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test,hvm
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 arch amd64
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 bios rombios
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 buildjob build-amd64
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 debianhvm_image debian-7.2.0-amd64-CD-1.iso
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 device_model_version qemu-xen-traditional
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 enable_stubdom true
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 enable_xsm false
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 kernbuildjob build-amd64-pvops
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 kernkind pvops
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 toolstack xl
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64 xenbuildjob build-amd64
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test,hvm
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm arch amd64
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm bios rombios
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm buildjob build-amd64-xsm
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm debianhvm_image debian-7.2.0-amd64-CD-1.iso
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm device_model_version qemu-xen-traditional
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm enable_stubdom true
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm enable_xsm true
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm kernbuildjob build-amd64-pvops
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm kernkind pvops
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm toolstack xl
+xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm xenbuildjob build-amd64-xsm
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 arch i386
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 bios rombios
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 buildjob build-i386
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 debianhvm_image debian-7.2.0-amd64-CD-1.iso
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 device_model_version qemu-xen-traditional
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 enable_stubdom true
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 enable_xsm false
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 kernbuildjob build-i386-pvops
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 kernkind pvops
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 toolstack xl
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64 xenbuildjob build-amd64
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm arch i386
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm bios rombios
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm buildjob build-i386-xsm
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm debianhvm_image debian-7.2.0-amd64-CD-1.iso
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm device_model_version qemu-xen-traditional
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm enable_stubdom true
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm enable_xsm true
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm kernbuildjob build-i386-pvops
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm kernkind pvops
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm toolstack xl
+xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm xenbuildjob build-amd64-xsm
> Ian.
prev parent reply other threads:[~2015-06-09 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 19:54 [PATCH OSSTEST v2] Stubdom test case Wei Liu
2015-06-09 10:36 ` Ian Campbell
2015-06-09 10:51 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609105131.GN29102@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.