From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Inha Song <ideal.song@samsung.com>
Cc: broonie@kernel.org, lee.jones@linaro.org,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] mfd: wm8994: Fix NULL pointer exception on missing pdata
Date: Tue, 9 Jun 2015 14:56:06 +0100 [thread overview]
Message-ID: <20150609135606.GF32730@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1433845112-371-1-git-send-email-ideal.song@samsung.com>
On Tue, Jun 09, 2015 at 07:18:32PM +0900, Inha Song wrote:
> If we use the dev_get_platdata, pdata can be NULL in DT environments.
> Actually, NULL pointer exception is occurs with error messages like this:
>
> [ 1.226583] Unable to handle kernel NULL pointer dereference at virtual address 00000044
> [ 1.467910] [<c02f1e38>] (wm8994_irq_init) from [<c02f1bd4>] (wm8994_i2c_probe+0x684/0x858)
> [ 1.476241] [<c02f1bd4>] (wm8994_i2c_probe) from [<c0371c78>] (i2c_device_probe+0x11c/0x17c)
>
> In wm8994-core, we already checked wheter platform data is NULL and set the
> wm8994->pdata to platform data if platform data is not NULL.
> So, we can use wm8994->pdata instead of platform data.
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
prev parent reply other threads:[~2015-06-09 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 10:18 [PATCH] mfd: wm8994: Fix NULL pointer exception on missing pdata Inha Song
2015-06-09 10:18 ` [alsa-devel] " Inha Song
2015-06-09 13:56 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609135606.GF32730@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ideal.song@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.