From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 2/4] EFI/early: add /mapbs to map
 EfiBootServices{Code, Data}
Date: Tue, 9 Jun 2015 10:11:44 -0400
Message-ID: <20150609141144.GH15200@x230>
References: <55770B190200007800082A2C@mail.emea.novell.com>
	<55770BDF0200007800082A43@mail.emea.novell.com>
	<5576F226.6080104@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1Z2KFw-00007f-Ba
	for xen-devel@lists.xenproject.org; Tue, 09 Jun 2015 14:11:56 +0000
Content-Disposition: inline
In-Reply-To: <5576F226.6080104@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Jun 09, 2015 at 03:03:18PM +0100, Andrew Cooper wrote:
> On 09/06/15 14:53, Jan Beulich wrote:
> > From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >
> > To help on certain platforms to run.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
> > --- a/xen/arch/x86/efi/efi-boot.h
> > +++ b/xen/arch/x86/efi/efi-boot.h
> > @@ -148,12 +148,16 @@ static void __init efi_arch_process_memo
> >  
> >          switch ( desc->Type )
> >          {
> > -        default:
> > -            type = E820_RESERVED;
> > -            break;
> > -        case EfiConventionalMemory:
> >          case EfiBootServicesCode:
> >          case EfiBootServicesData:
> > +            if ( map_bs )
> 
> if ( !map_bs ) surely?  It is the else case which sets a type of E820_RAM.

We want the EfiBootServices{Code|Data} to be E820_RESERVED and this
sets it to that if map_bs is set.

If map_bs is not set then we treat it as E820_RAM.